463275 - Edit Recurrence dialog shows wrong rule when editing event

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Stefan Sitter [:ssitter]]

Attachment: Testcase from Bug 365034

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081105 Calendar/1.0pre (BuildID: 20081105110610)

Steps to Reproduce:
1. Start Sunbird with clean profile
2. Import the attached testcase that was taken from Bug 365034
3. Open the event for editing, choose "Edit all occurrences" when prompted
4. Choose "Custom..." from the Repeat dropdown menu

Actual Results:
Recurrence summary in the Edit Event dialog correctly shows "Occurs every December 26 effective 12/26/2006.". But in the Edit Recurrence dialog the selection is incorrectly set to "Annually. Every [1] [January|v]".

Expected Results:
Correct recurrence rule is pre-selected in the Edit Recurrence dialog.

Error Console doesn't report anything.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

This patch takes care of correctly loading the recurrence and also modifies the saving behavior. I'm a bit unsure if this is user-friendly though:

* Originally, we used to compose a rule BYMONTH=12;BYMONTHDAY=26 if dec 26 was
  selected
* Now, when the recurrence dialog is opened and the user enters the same month
  and day as the item starts on, we compose a rule BYMONTH=12.
  - When the user changes the start date, the recurrence details get updated

As an alternative, we could just stay with the old behavior and modify the recurrence rule. This could be bad w.r.t iTIP/iMIP though.

Comment 2

[Stefan Sitter [:ssitter]]

Comment on attachment 358602 [details] [diff] [review]
Fix - v1

The changes when loading the event looks OK. The changes when saving the event are not required in my opinion, as already discussed on IRC. With or without the change there are recurrence rules that get changed on save although the user changed nothing in the recurrence dialog. I'd keep the current behavior to ensure consistency with the previous releases.

Comment 3

[Stefan Sitter [:ssitter]]

Comment on attachment 358602 [details] [diff] [review]
Fix - v1

I'd give r+ for the load changes but the save changes are still under discussion. Philip said about three weeks ago on IRC that an updated patch will be posted after discussion. Denying review request for now.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

I've decided to take the load changes only and will take the r+ from comment 3 :-)

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/c93871cba778>
-> FIXED

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

This bug was also pushed to comm-beta and comm-aurora, likely during the last merge.