463282 - Tasks cannot be created or imported

Status: VERIFIED FIXED

(Calendar :: Provider: Local Storage, defect)

Description

[Stefan Sitter [:ssitter]]

Attachment: Testcase from Bug 383462

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081105 Calendar/1.0pre (BuildID: 20081105110610)

Steps to Reproduce:
1. Start Sunbird with clean profile
2. Import the attached testcase that was taken from Bug 383462

Actual Results:
Import fails. Console shows:
********** mozStorageStatementWrapper: Couldn't find parameter :event_stamp

Alert dialog shows:
1 items failed to import. The last error was: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [calICalendar.addItem]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://calendar/content/import-export.js :: putItemsIntoCal :: line 191"  data: no]

Additional Information:
Works in Sunbird 0.7 ... Sunbird 0.9, fails in Sunbird 1.0pre -> regression

Comment 1

[Stefan Sitter [:ssitter]]

Error can also be reproduced by using the following steps:
1. Create new task
2. Set it to repeat daily
3. Try to save tasks

Comment 2

[Stefan Sitter [:ssitter]]

Regression range: Works in Sunbird 1.0pre (20081104050504)
                  Fails in Sunbird 1.0pre (20081105034730)

Seems to be regressed by Bug 457203.

Comment 3

[Daniel Boelzle [:dbo]]

Attachment: fix - v1

Comment 4

[Stefan Sitter [:ssitter]]

There seems to be an issue with opening the upgrade profile (with database schema 15) in a previous build. I get the expected "Upgraded ... data incompatible ... Sunbird will quit" dialog. But in the background Sunbird uses 100% of CPU and hangs the system. Trying to close the Quit-dialog has no effects. The Sunbird process had to be killed via Task-Manager.

Comment 6

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 346646 [details] [diff] [review]
fix - v1

Must DTSTAMP not be set quite late in the game, similar to LAST-MODIFIED?

r=philipp with question considered

Comment 7

[Daniel Boelzle [:dbo]]

Comment on attachment 346646 [details] [diff] [review]
fix - v1

requesting 2nd review due to schema change

Comment 8

[Daniel Boelzle [:dbo]]

(In reply to comment #4)
Stefan, could you please file follow-up bug for that?


(In reply to comment #6)
> Must DTSTAMP not be set quite late in the game, similar to LAST-MODIFIED?
It's not necessary. The "init-as-is-without-modification" is just tied to setting the LAST-MODIFIED property.

Comment 10

[Berend Cornelius]

Comment on attachment 346646 [details] [diff] [review]
fix - v1

looks good; r=berend.

Comment 11

[Daniel Boelzle [:dbo]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/8beded258a4b>

-> FIXED

Comment 12

[bill cenci]

Does this mean it has been fixed in the nightly builds of lightning using Thunderbird 3.01b pre?

Comment 13

[Przemyslaw Bialik]

-> VERIFIED

build 20081112060034 (Win + Mac)

re#12 yes, it does