Closed Bug 463367 Opened 16 years ago Closed 15 years ago

Remove EULA from Thunderbird installer / .dmg and related bits

Categories

(Thunderbird :: Installer, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 3.0b2

People

(Reporter: gkw, Assigned: standard8)

References

Details

(Whiteboard: [has l10n impact])

Attachments

(8 files, 3 obsolete files)

Thunderbird equivalent of bug 462254. This bug removes the EULA for all platforms at installation for Firefox.

Background at that bug:
"Bug 456439 adds a new "about:rights" page and notification bar. The intention
is for that to also replace the current EULA stuff that's shown to Windows and
OS X users when installing Firefox. [The about:rights notification bar isn't
shown if the user was already shown the EULA.]"

Thunderbird should probably do the same, with the about:rights part and such. The best way forward and how they should all fit together in a mail client should be first discussed. Part of the start page?
Flags: blocking-thunderbird3?
The start page would probably make sense.  With the notification bar we could even reach those who have turned off the start page.

Though I'm kind of wondering if we could just put the EULA in an email from "Thunderbird", subject: "Your Rights".  Not sure how difficult that would be, but some places it makes more sense to me for us to spread our wings as a communication client than copy firefox.
Sounds like a fine idea to me -- it allows users to treat it just like any other piece of mail-contained information.
I think we want this...
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Priority: -- → P2
Target Milestone: --- → Thunderbird 3.0b2
I'm not sure we have the time to setup a fake server, fake accounts, etc.  I would rather go for something simple like the notification bar.
I've not looked at how Firefox does it, but we've got to display it somehow? So how about a new tab on first startup similar to what we do with the what's new page?
I think we can display the notification bar on that what's new tab page.  I'm not sure we need another new tab with with the about:rights page if that's what you're suggesting.
In regards to putting it in an email - why not just load it directly into the mailbox during setup (or immidiately after the mailbox is created)?
we can do the e-mail thing - we've done it in the past, and there's still code for it in the tree. For IMAP users, it's a bit funky since the e-mail will go in the local folders inbox, iirc.
Assignee: nobody → bugzilla
Whiteboard: [affects l10n]
Status: NEW → ASSIGNED
Here's what Firefox currently displays on nightly builds for about:rights.

The top image is the official builds (i.e. those with MOZILLA_OFFICIAL set in the environment when building) and the bottom one is the unofficial builds.

I'm putting them here for reference to compare with what I'm proposing for the Thunderbird about:rights display.
Attached image Proposed text for Thunderbird (obsolete) —
Here's what I'm proposing for Thunderbird. Again, the official build text is at the top (in this case I've also got the official branding on as well), the unofficial build is at the bottom.

The links in order are:
http://www.mozilla.org/MPL/
http://www.mozilla.org/foundation/trademarks/policy.html
http://www.mozilla.com/en-US/legal/privacy/

Notes:
- I've dropped the webservices section from both the official and unofficial sections. AFAIK we don't use safe browsing. Though should we be keeping the text in the unofficial branding section?
- Also, the privacy policy link is currently direct to MoCo's site and only has a privacy policy for Firefox.

Asking review from David as he's probably the best person to review the text.

The current plan is:

1) Get about:rights into the build so that l10n can work on the strings
2) Get code to open about:rights in a new tab into the build
3) Sort out a notification bar (somehow) and remove the current EULA
Attachment #359279 - Flags: review?(david.ascher)
Attached patch Implement about:rights (obsolete) — Splinter Review
Attachment #359280 - Flags: review?(philringnalda)
Attachment #359279 - Flags: review?(david.ascher) → review-
Comment on attachment 359279 [details]
Proposed text for Thunderbird

* even shredder builds should have a trademark/logo line, mentioning Mozilla.

* even shredder builds should have the privacy policy line.

* i wonder if we should keep the services line to refer e.g. to the update and add-on checking services.  I'll talk to legal and find out. (note that i still have bug 368924 on my plate.  )
(In reply to comment #12)
> (From update of attachment 359279 [details])
> * even shredder builds should have a trademark/logo line, mentioning Mozilla.
> 
> * even shredder builds should have the privacy policy line.

Sorry I should have possibly explained a bit more. The bottom images are what we display in self compiled builds. The top images are what are/will be official builds i.e. any build that comes off tinderboxes and will show Shredder or Thunderbird as appropriate - to do an official build, you have to set MOZILLA_OFFICIAL in the environment (which our boxes do do).

> * i wonder if we should keep the services line to refer e.g. to the update and
> add-on checking services.  I'll talk to legal and find out. (note that i still
> have bug 368924 on my plate.  )

Firefox doesn't do this, but I did notice them being referenced in the privacy policy.
Is something missing from the patch, besides putting aboutRights.js in packages-static? I'd expect typeof(Components.classes["@mozilla.org/network/protocol/about;1?what=rights"]) to be undefined in a packaged Windows build, but I'm not seeing why it's also undefined in a Mac build.
Harvey agrees w/ me that we need language to refer to both the service terms (even if we don't have the specific one highlighted in Firefox's about:rights), and explained that we also need the warranty disclaimer.

Thus, the following paragraph:

  Thunderbird also offers optional services, such as the add-on update service; however, we cannot guarantee they are 100% accurate or error-free. More details, including information on how to disable the services, can be found in the service terms.
Attachment #359280 - Flags: review?(philringnalda) → review+
Comment on attachment 359280 [details] [diff] [review]
Implement about:rights

Apparently, the only thing missing was my ability to actually apply a patch and build with it applied and then run the result of that build.

I don't actually _like_ the l10n, where fifty-odd locales have to translate a string that really means to say "Hey, RoncoMailClient 3000 distributor, you need to change this string!," but I guess it was good enough for Firefox, and any change like putting the varying bits in brand.dtd as "" with a comment are likely to make it even harder for localizers to see the effect of their work in a release build, where it really matters.

r=me with aboutRights.js added to packages-static, and the strings you wind up agreeing on.
Whiteboard: [affects l10n] → [has l10n impact]
Attached image Proposed text for Thunderbird v2 (obsolete) —
This is the proposed text for MoMo generated builds (Shredder/Thunderbird) with the services section now showing as well and the paragraph from comment 15.

I'm not sure that paragraph 1 is correct, and some of the rest may need tweaking as well (this is mainly copied direct from Firefox).
Attachment #359279 - Attachment is obsolete: true
Comment on attachment 360466 [details]
Proposed text for Thunderbird v2

David, please see comment 17.
Attachment #360466 - Flags: review?(david.ascher)
This is now the text for unofficial builds (i.e. without MOZILLA_OFFICIAL, e.g. developer builds).
Attachment #360468 - Flags: review?(david.ascher)
Depends on: 477029
(In reply to comment #18)
> (From update of attachment 360466 [details])
> David, please see comment 17.

Para 1 does seem slightly off, because the anti-phishing feature in TB is not services-based, but based on regular expressions, AFAIK.  We also don't do malware detection in Thunderbird AFAIK.  So I suspect the sentence needs changing, and possibly moving out of the Services section.

Harvey, your thoughts?
Whiteboard: [has l10n impact] → [has l10n impact][waiting legal comment
Whiteboard: [has l10n impact][waiting legal comment → [has l10n impact][waiting legal comment][waiting ui-review]
The patch isn't ready yet, but here's what I proposing for the notification bar, it is shown regardless of the tab displayed.

I think it is cleaner along the bottom of the window and it means that if we ever end up displaying different initial tabs then we won't be dependent on the mail tab being displayed to show the notification bar.

I did look to see how weave did this, but I thought to have the notification in a popup with an icon isn't quite as obvious as it should be for something like this.

Clicking the button will bring up the about:rights tab as per the other screenshots on this bug.

Asking Bryan for his thoughts on the position etc.
Attachment #361096 - Flags: ui-review?(clarkbw)
Whiteboard: [has l10n impact][waiting legal comment][waiting ui-review] → [has l10n impact][waiting legal comment][waiting ui-review][need review philor on bug 477029]
(In reply to comment #20)
> (In reply to comment #18)
> > (From update of attachment 360466 [details] [details])
> > David, please see comment 17.
> 
> Para 1 does seem slightly off, because the anti-phishing feature in TB is not
> services-based, but based on regular expressions, AFAIK.  We also don't do
> malware detection in Thunderbird AFAIK.  So I suspect the sentence needs
> changing, and possibly moving out of the Services section.
> 
> Harvey, your thoughts?

Para 1 is a bit off as you observed. Suggest the following:

Under Shredder Web Site Services:

Line 1/1st Para/1st sentence: Change to "Shredder offers optional services ("Services")..."

Para 1: Delete it entirely and renumber paragraphs. Don't need para 1 if there are not antiphishing services.
Attachment #361096 - Attachment is patch: false
Attachment #361096 - Attachment mime type: text/plain → image/png
Revised text with Harvey's changes.
Attachment #360466 - Attachment is obsolete: true
Attachment #361148 - Flags: review?(david.ascher)
Attachment #360466 - Flags: review?(david.ascher)
Attachment #361148 - Attachment is patch: false
Attachment #361148 - Attachment mime type: text/plain → image/png
Updated patch with new text
Attachment #359280 - Attachment is obsolete: true
Attachment #361150 - Flags: review+
Comment on attachment 361148 [details]
Proposed text for Thunderbird v3

looks good.
Attachment #361148 - Flags: review?(david.ascher) → review+
Attachment #360468 - Flags: review?(david.ascher) → review+
(In reply to comment #21)
> Created an attachment (id=361096) [details]
> about:rights notification bar
> 
> The patch isn't ready yet, but here's what I proposing for the notification
> bar, it is shown regardless of the tab displayed.
> 
> I think it is cleaner along the bottom of the window and it means that if we
> ever end up displaying different initial tabs then we won't be dependent on the
> mail tab being displayed to show the notification bar.

I had a look at putting this at the top of the page and its not easy. I think I'd need to hook it in via an xml file. So I'd like to put it at the bottom for the first version at least (so we can get the remaining strings in) and then put it at the top later if we want to.
Comment on attachment 361150 [details] [diff] [review]
[checked in] Implement about:rights v2

Checked in this part: http://hg.mozilla.org/comm-central/rev/99c7ad5e6ec7

If localisers want to view/test this before the second part lands, put about:rights as the mail start page and then select Go -> Mail Start Page.
Attachment #361150 - Attachment description: Implement about:rights v2 → [checked in] Implement about:rights v2
Here's the patch to add the notification and about:rights tab. The logic is largely based on how Firefox does it (though we didn't have previous versions of the EULA to worry about).

Notes:
- Display is disabled for debug or non-official builds.
- I've allowed the about panel definition to be generic so it can load more types of about: urls (for possible future use).
- The iframe is a content one (and defined in the xul) so that page load and display works correctly (i.e. we get the css on the links). I did try doing it in a similar way to the whatsnew tab but that didn't want to work correctly.
- notification bar at bottom of window per previous comments.

I'll attach the installer changes as separate patches.
Attachment #361162 - Flags: review?(philringnalda)
This removes the EULA from the mac build in favour of the new about:rights notification.
Attachment #361164 - Flags: review?(bienvenu)
Whiteboard: [has l10n impact][waiting legal comment][waiting ui-review][need review philor on bug 477029] → [has l10n impact][need reviews philor,bienvenu][windows installer patch todo]
This is based around the patch in bug 462254 except we don't need the toolkit changes because they are already there.
Attachment #361179 - Flags: review?(philringnalda)
Comment on attachment 361162 [details] [diff] [review]
[checked in] Add about notification and tab v1

r=me with

>-  <statusbar id="status-bar" class="chromeclass-status">
>-    <statusbarpanel id="unreadMessageCount"/>
>-    <statusbarpanel id="totalMessageCount"/>
>-  </statusbar>
>+  <notificationbox id="mail-notification-box"/>
>+    <statusbar id="status-bar" class="chromeclass-status">
>+      <statusbarpanel id="unreadMessageCount"/>
>+      <statusbarpanel id="totalMessageCount"/>
>+    </statusbar>
>+  <notificationbox/>

out that :), and

>+  showAboutRightsNotification: function(prefs) {
>+    // Stick the notification onto the selected tab of the active browser window.

always, always, file the serial numbers off anything you steal, first thing.
Attachment #361162 - Flags: review?(philringnalda) → review+
Attachment #361164 - Flags: review?(bienvenu) → review+
Comment on attachment 361164 [details] [diff] [review]
[checked in] Remove EULA from mac build

Stealing this review, just for the chance to pound away on its coffin nails after seeing that EULA six or eight times a day.
Comment on attachment 361179 [details] [diff] [review]
[checked in] Remove EULA from win build

Looks good to me.
Attachment #361179 - Flags: review?(philringnalda) → review+
Comment on attachment 361096 [details]
about:rights notification bar

looks good
Attachment #361096 - Flags: ui-review?(clarkbw) → ui-review+
Whiteboard: [has l10n impact][need reviews philor,bienvenu][windows installer patch todo] → [has l10n impact][needs ui-review clarkbw]
Keywords: push-needed
Whiteboard: [has l10n impact][needs ui-review clarkbw] → [has l10n impact][has patch]
Keywords: push-needed
Comment on attachment 361162 [details] [diff] [review]
[checked in] Add about notification and tab v1

Checked in: http://hg.mozilla.org/comm-central/rev/e7d4e8d57e63
Attachment #361162 - Attachment description: Add about notification and tab v1 → [checked in] Add about notification and tab v1
Comment on attachment 361164 [details] [diff] [review]
[checked in] Remove EULA from mac build

Checked in: http://hg.mozilla.org/comm-central/rev/e7d4e8d57e63
Attachment #361164 - Attachment description: Remove EULA from mac build → [checked in] Remove EULA from mac build
Comment on attachment 361164 [details] [diff] [review]
[checked in] Remove EULA from mac build

Actually this one was: http://hg.mozilla.org/comm-central/rev/65d4ea01e359
Comment on attachment 361179 [details] [diff] [review]
[checked in] Remove EULA from win build

Checked in: http://hg.mozilla.org/comm-central/rev/6193341b49cb
Attachment #361179 - Attachment description: Remove EULA from win build → [checked in] Remove EULA from win build
This bug is now fixed.

We should probably be updating litmus for this bug. Here's a quick set of suggested steps for integration into litmus:

Two tests that should be done with
- new profile
- Existing profile where "mail.rights.version" is set to 0 initially

1a) Check the notification bar is displayed
1b) Once past the account manager, check can open about:rights by clicking the button (and the bar goes away).
1c) Check doesn't reappear on subsequent launch.

2a) Check the notification bar is displayed
2b) Click the 'x' and check bar goes away
2c) Check doesn't reappear on subsequent launch.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-litmus?
Resolution: --- → FIXED
Whiteboard: [has l10n impact][has patch] → [has l10n impact]
This turned out real nicely - great job!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.