463692 - Clear the findbar text when leaving the private browsing mode

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

The equivalent of bug 463202 for the findbar.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

This patch is very similar to that of bug 463202.

I think it would be good to have this for beta 2.

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 346951 [details] [diff] [review]
Patch (v1)

Yep, ship it.

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/d8295ec827fa

Comment 4

[Marcia Knous [:marcia]]

verified fixed using  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081111 Minefield/3.1b2pre and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081111 Minefield/3.1b2pre.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_findbar.js | entering the private browsing mode should not clear the findbar - Got , expected privatebrowsing

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_findbar.js | entering the private browsing mode should not reset the undo list of the findbar control

Comment 6

[Marcia Knous [:marcia]]

Is someone investigating why the two tests in Comment 5 fail?  In the meantime, I think I am going to add a basic test for this in Litmus.

Comment 7

[(no longer active)]

Mass moving of all Firefox::General private browsing bugs to Firefox::Private Browsing.

Comment 8

[(no longer active)]

(In reply to comment #6)
> Is someone investigating why the two tests in Comment 5 fail?

I have not been able to reproduce this locally at all.  Smaug: have you seen this on Tinderbox?  Can you reproduce this locally?  What platform are you using?

> In the meantime,
> I think I am going to add a basic test for this in Litmus.

Thanks, I've marked this in-litmus?.

Comment 9

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=7441 added to Litmus