Closed Bug 463692 Opened 11 years ago Closed 11 years ago

Clear the findbar text when leaving the private browsing mode

Categories

(Firefox :: Private Browsing, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 3.1b2

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

(Keywords: privacy, verified1.9.1)

Attachments

(1 file)

The equivalent of bug 463202 for the findbar.
Attached patch Patch (v1)Splinter Review
This patch is very similar to that of bug 463202.

I think it would be good to have this for beta 2.
Attachment #346951 - Flags: review?(mconnor)
Attachment #346951 - Flags: approval1.9.1b2?
Comment on attachment 346951 [details] [diff] [review]
Patch (v1)

Yep, ship it.
Attachment #346951 - Flags: review?(mconnor)
Attachment #346951 - Flags: review+
Attachment #346951 - Flags: approval1.9.1b2?
Attachment #346951 - Flags: approval1.9.1b2+
http://hg.mozilla.org/mozilla-central/rev/d8295ec827fa
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b2
verified fixed using  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081111 Minefield/3.1b2pre and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081111 Minefield/3.1b2pre.
Status: RESOLVED → VERIFIED
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_findbar.js | entering the private browsing mode should not clear the findbar - Got , expected privatebrowsing

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_findbar.js | entering the private browsing mode should not reset the undo list of the findbar control
Is someone investigating why the two tests in Comment 5 fail?  In the meantime, I think I am going to add a basic test for this in Litmus.
Mass moving of all Firefox::General private browsing bugs to Firefox::Private Browsing.
Component: General → Private Browsing
QA Contact: general → private.browsing
(In reply to comment #6)
> Is someone investigating why the two tests in Comment 5 fail?

I have not been able to reproduce this locally at all.  Smaug: have you seen this on Tinderbox?  Can you reproduce this locally?  What platform are you using?

> In the meantime,
> I think I am going to add a basic test for this in Litmus.

Thanks, I've marked this in-litmus?.
Flags: in-litmus?
https://litmus.mozilla.org/show_test.cgi?id=7441 added to Litmus
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.