Created attachment 346963 [details] screenshot The icon and preview image for Sunbird default theme are missing in add-on manager, see screenshot. Regression range: Works in Sunbird 1.0pre (20081021035436) Fails in Sunbird 1.0pre (20081022032438) Most probably regressed by Bug 290747.
Created attachment 346981 [details] [diff] [review] Fix - v1 This fixes. it seems that "classic.jar" can contain the icon and preview for the default theme, but the way extensions do it is to put the files in the root of the theme. I'm going with the latter solution since it also works and seems more consistant.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #346981 - Flags: review?(daniel.boelzle)
Comment on attachment 346981 [details] [diff] [review] Fix - v1 r=dbo
Attachment #346981 - Flags: review?(daniel.boelzle) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/f49e757f1f93> -> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Created attachment 347516 [details] [diff] [review] Fix packages-static/removed-files.in r=dbo over the shoulder, this takes care of removing the classic.jar from existing installs. QA: Some update testing would be nice :-)
Attachment #347516 - Flags: review+
Extra fixed pushed to comm-central <http://hg.mozilla.org/comm-central/rev/a5f811d59d97>
Why is classic.jar obsolete? Doesn't it contain all the toolkit styles and images?
You are right, sorry about that. I'll back out that change.
backout changeset is 13e258959c0e
Issue still exists using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081112 Calendar/1.0pre (BuildID: 20081112033628).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 347783 [details] [diff] [review] fix packages-static
Comment on attachment 347783 [details] [diff] [review] fix packages-static Ah yes, thanks. packages-static always gets me off track :-} r=philipp
Attachment #347783 - Flags: review?(philipp) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/719722181ac9> -> FIXED
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago → 10 years ago
Resolution: --- → FIXED
Checked in sunbird buils 20081112 -> VERIFIED.
Status: RESOLVED → VERIFIED
Seems to be guilty for bug 465048 ?!
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.