Closed Bug 463793 Opened 11 years ago Closed 11 years ago

aboutCertError lacks twisties on Windows Vista

Categories

(Firefox :: Theme, defect)

x86
Windows Vista
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 3.1b2

People

(Reporter: whimboo, Assigned: johnath)

References

(Blocks 1 open bug, )

Details

(Keywords: regression, verified1.9.1)

Attachments

(4 files, 1 obsolete file)

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081107 Minefield/3.1b2pre ID:20081107224438

With the overhaul of the security error page ui in bug 431826 the twisties aren't shown on Vista. They are present on OS X. Do we still lack the icons for winstripe or do we have a wrong reference? See the attached screenshot.
When Gavin reminded me in his review to add the stylesheet to both xp and vista versions of winstripe, I should have remembered to add the icons too.

Patch incoming.
Assignee: kaie → johnath
Status: NEW → ASSIGNED
Component: Security: UI → Theme
Product: Core → Firefox
QA Contact: ui → theme
Flags: blocking-firefox3.1?
Attachment #347088 - Flags: review?(gavin.sharp) → review+
Attachment #347088 - Flags: approval1.9.1b2?
Attachment #347088 - Flags: approval1.9.1b2? → approval1.9.1b2+
http://hg.mozilla.org/mozilla-central/rev/1e69ed317645
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081110 Minefield/3.1b2pre.
Status: RESOLVED → VERIFIED
Sorry, that I've to reopen the bug but there is a visual aspect left for these twisties. The vertical alignment is odd. For both states the twisties need more padding at the top to align correctly with the heading. See the attached screenshot.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Flags: blocking-firefox3.1? → blocking-firefox3.1+
Attachment #347550 - Flags: review?(gavin.sharp)
Attachment #347550 - Flags: approval1.9.1b2?
I like this more than fixed pixel-size padding - it's also more survivable if default fonts change, or if we otherwise restyle those h2s
Attachment #347550 - Attachment is obsolete: true
Attachment #347554 - Flags: review?(gavin.sharp)
Attachment #347554 - Flags: approval1.9.1b2?
Attachment #347550 - Flags: review?(gavin.sharp)
Attachment #347550 - Flags: approval1.9.1b2?
Attachment #347554 - Flags: review?(gavin.sharp) → review+
Attachment #347554 - Flags: approval1.9.1b2? → approval1.9.1b2+
Comment on attachment 347554 [details] [diff] [review]
Even simpler - just center the background twistie

a=beltzner
http://hg.mozilla.org/mozilla-central/rev/b3264ec54911

Twistie is now centered within the h2 element. On WinXP, this styling change makes no visible difference.  On Vista it's now aligned properly (sometimes I think it should be a pixel lower than it is, sometimes I think it's fine.  I think I'll trust the CSS here or, failing that, file a new bug).
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
We should be using native tree expansion controls to help enforce that this isn't some random web page, to avoid introducing non-platform native colors, and to reduce how many redundant images we have checked in.
Blocks: 464677
(In reply to comment #11)
> We should be using native tree expansion controls to help enforce that this
> isn't some random web page, to avoid introducing non-platform native colors,
> and to reduce how many redundant images we have checked in.

I agree - I couldn't find a bug for it, so I filed bug 464677
Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081114 Minefield/3.1b2pre ID:20081114034305
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 3.1b2
You need to log in before you can comment on or make changes to this bug.