463793 - aboutCertError lacks twisties on Windows Vista

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: No twisties for neterror:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081107 Minefield/3.1b2pre ID:20081107224438

With the overhaul of the security error page ui in bug 431826 the twisties aren't shown on Vista. They are present on OS X. Do we still lack the icons for winstripe or do we have a wrong reference? See the attached screenshot.

Comment 1

[Johnathan Nightingale [:johnath]]

When Gavin reminded me in his review to add the stylesheet to both xp and vista versions of winstripe, I should have remembered to add the icons too.

Patch incoming.

Comment 2

[Johnathan Nightingale [:johnath]]

Attachment: Add the icons to the second half of jar.mn

Comment 3

[Johnathan Nightingale [:johnath]]

http://hg.mozilla.org/mozilla-central/rev/1e69ed317645

Comment 4

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081110 Minefield/3.1b2pre.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry, that I've to reopen the bug but there is a visual aspect left for these twisties. The vertical alignment is odd. For both states the twisties need more padding at the top to align correctly with the heading. See the attached screenshot.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: vertical miss-alignment

Comment 7

[Johnathan Nightingale [:johnath]]

Attachment: 3px padding for vista (requires creating new -aero css file)

Comment 8

[Johnathan Nightingale [:johnath]]

Attachment: Even simpler - just center the background twistie

I like this more than fixed pixel-size padding - it's also more survivable if default fonts change, or if we otherwise restyle those h2s

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 347554 [details] [diff] [review]
Even simpler - just center the background twistie

a=beltzner

Comment 10

[Johnathan Nightingale [:johnath]]

http://hg.mozilla.org/mozilla-central/rev/b3264ec54911

Twistie is now centered within the h2 element. On WinXP, this styling change makes no visible difference.  On Vista it's now aligned properly (sometimes I think it should be a pixel lower than it is, sometimes I think it's fine.  I think I'll trust the CSS here or, failing that, file a new bug).

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

We should be using native tree expansion controls to help enforce that this isn't some random web page, to avoid introducing non-platform native colors, and to reduce how many redundant images we have checked in.

Comment 12

[Johnathan Nightingale [:johnath]]

(In reply to comment #11)
> We should be using native tree expansion controls to help enforce that this
> isn't some random web page, to avoid introducing non-platform native colors,
> and to reduce how many redundant images we have checked in.

I agree - I couldn't find a bug for it, so I filed bug 464677

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081114 Minefield/3.1b2pre ID:20081114034305