464006 - Error: key is null Bronbestand: file:///C:/Program%20Files/Mozilla%20Firefox/components/nsUrlClassifierLib.js Regel: 1173

Status: RESOLVED DUPLICATE of bug 447648

(Toolkit :: Safe Browsing, defect)

Description

[Bart]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; nl; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; nl; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3

I get this error, when i visit routenet.nl. if i clean up private data. reload the page i get this error:

Error: key is null Bronbestand: file:///C:/Program%20Files/Mozilla%20Firefox/components/nsUrlClassifierLib.js Regel: 1173

PROT_UrlCryptoKeyManager.prototype.unUrlSafe = function(key)
{
    return key.replace("-", "+").replace("_", "/");
}


Reproducible: Always

Steps to Reproduce:
1. clean private data
2. reload routenet.nl
3.
Actual Results:  
Fout: key is null
Bronbestand: file:///C:/Program%20Files/Mozilla%20Firefox/components/nsUrlClassifierLib.js
Regel: 1173

Expected Results:  
reload the page

Comment 1

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081108 Minefield/3.1b2pre

This works fine for me.

Comment 2

[Marcus Redivo]

For me, it looks like this:

[Exception... "'[JavaScript Error: "key is null" {file:
"file:///D:/projects/Flock/flock-trunk/objectdir/dist/bin/components/nsUrlClassifierLib.js"
line: 2158}]' when calling method: [nsIObserver::observe]"  nsresult:
"0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame
:: chrome://browser/content/sanitize.js :: anonymous :: line 80"  data: yes]

Patch coming up.

Comment 3

[Marcus Redivo]

Attachment: Test "key" for null before dereferencing it

This function is only called from one place, and it doesn't matter what is returned in the "key == null" case. I arbitrarily chose "".

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 348116 [details] [diff] [review]
Test "key" for null before dereferencing it

I guess the code path here is PROT_UrlCryptoKeyManager.prototype.dropKey calling replaceKey_(null, null) which in turn calls unUrlSafe(null)... would be good to get someone who's really familiar with this code to check whether there isn't a larger problem being exposed here (seems to me that this would mean at least part of replaceKeys is never hit when called from dropKeys, which appears to be called each time cookies are cleared?).

Comment 5

[Tony Chang (Google)]

It seems like the fix should be in http://mxr.mozilla.org/firefox/source/toolkit/components/url-classifier/content/url-crypto-key-manager.js#275 to not set clientKeyArray and serializeKey_ should just delete the key on disk.

That said, I'm confused why we don't hit this code path in the wild or maybe we are and no one has noticed?

Comment 6

[Marcus Redivo]

(In reply to comment #5)
> ...
> That said, I'm confused why we don't hit this code path in the wild or maybe we
> are and no one has noticed?

I only saw this because I was running a debug build of Flock (based on FF3), and it appeared on the console.

I opened the JS error window in Firefox, cleared the cookies, and sure enough, saw the error being logged.

I expect it is 100% reproducible.

Comment 7

[Rajiv Bandi]

I just upgraded my Firefox Installation to 3.0.5 (from 3.0.4).
Still getting this error.
Steps to reproduce the error.
1)clear private data

that's all.
Hope this helps.

Comment 8

[Rajiv Bandi]

Attachment: ScreenShot of the error