447648 - error message when clearing cookies

Status: VERIFIED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[R. Hirschfeld]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1

Since updating to 3.0.1, I notice that when removing all cookies the following error is reported in the Error Console:

Error: key is null
Source File: file:///Applications/Firefox.app/Contents/MacOS/components/nsUrlClassifierLib.js
Line: 1173


Reproducible: Always

Steps to Reproduce:
1. Select "Tools->Clear Private Data..." from menu
2. Check "Cookies"
3. Click "Clear Private Data Now"

Alternatively, select "Firefox->Preferences", click "Show Cookies...", and click "Remove All Cookies".
Actual Results:  
Cookies are cleared and an error is reported in the Error Console.

Error: key is null
Source File: file:///Applications/Firefox.app/Contents/MacOS/components/nsUrlClassifierLib.js
Line: 1173

Expected Results:  
Cookies are cleared without error.

If the cookies are removed one by one, no error is reported after removing the last one.

I classified this bug as minor because I haven't noticed any loss of functionality, but it could reflect a more serious problem.

Comment 1

[Tyler Downer [He/Him]]

Can you try this in Safe Mode (http://support.mozilla.com/en-US/kb/Safe+Mode).

Comment 2

[R. Hirschfeld]

I started Mozilla in Safe Mode, tried again and observed the same behavior, no difference.

Comment 3

[R. Hirschfeld]

Sorry, I wrote Mozilla but I meant Firefox of course.  I did:

/Applications/Firefox.app/Contents/MacOS/firefox -safe-mode &

Comment 4

[Steven Michaud [:smichaud] (Retired)]

I don't see any error messages in the console when I clear all cookies.  I tested on OS X 10.5.4 (with FF 3.0.1).

What error messages do you see in the console?

Comment 5

[R. Hirschfeld]

Strange, I am also using FF 3.0.1 on OS X 10.5.4 and I get the error message every time.  It is the "key is null" error I mentioned in the original bug report.  The line it refers to (line 1173 of nsUrlClassifierLib.js) is the line "return key.replace("-", "+").replace("_", "/");", which is the entirety of the function PROT_UrlCryptoKeyManager.prototype.unUrlSafe.

Comment 6

[R. Hirschfeld]

Additional info: I'm certain I did not see this with FF 2.0.0.14 but I wasn't sure about FF 3.0, so I uninstalled FF 3.0.1 and reinstalled FF 3.0 (I still have the .dmg).  With FF 3.0 I get a DIFFERENT error when clearing all cookies:

Error: this.keyManager_ is null
Source File: file:///Applications/Firefox.app/Contents/MacOS/components/nsUrlClassifierListManager.js
Line: 511

Line 511 is the line "this.keyManager_.dropKey();" in the following function:

/**
 * Called when cookies are cleared - clears the current MAC keys.
 */
PROT_ListManager.prototype.cookieChanged_ = function(subject, topic, data) {
  if (data != "cleared")
    return;

  G_Debug(this, "cookies cleared");
  this.keyManager_.dropKey();
}

I find it odd that others are unable to reproduce this as I have a very vanilla installation.

Comment 7

[Steven Michaud [:smichaud] (Retired)]

Your problem might be caused by a corrupt profile.

Test with a fresh profile and see if this makes the problem go away.

The easiest way to give yourself a fresh profile (and one which is
reversible, if need be) is:

1) Quit Firefox.

2) In Terminal, rename the Firefox directory in ~/Library/Application
   Support/ to something like Firefox.old.

3) Restart Firefox and visit a bunch of commercial sites like
   apple.com (there are no cookies in your fresh profile, so you need
   to collect a few).

4) Test your STRs from comment #0.

Comment 8

[R. Hirschfeld]

(In reply to comment #7)
> Your problem might be caused by a corrupt profile.
> 
> Test with a fresh profile and see if this makes the problem go away.
> 
> The easiest way to give yourself a fresh profile (and one which is
> reversible, if need be) is:
> 
> 1) Quit Firefox.
> 
> 2) In Terminal, rename the Firefox directory in ~/Library/Application
>    Support/ to something like Firefox.old.
> 
> 3) Restart Firefox and visit a bunch of commercial sites like
>    apple.com (there are no cookies in your fresh profile, so you need
>    to collect a few).
> 
> 4) Test your STRs from comment #0.
> 

I tried with a fresh profile and got exactly the same result (I omitted the cookie-collection step because the error occurs whether or not there are any cookies stored).

Comment 10

[(no longer active)]

Attachment: Patch (v1) [Checkin: Comment 15]

For the rationale behind the patch, see bug 455454.

Comment 11

[Johnathan Nightingale [:johnath]]

Ehsan - thanks for taking a look here.  I believe your patch doesn't address comment 6, but that might be its own bug, really.

Comment 12

[Johnathan Nightingale [:johnath]]

(Urr - I *meant* Phishing protection, not places, clearly).

Comment 13

[(no longer active)]

(In reply to comment #11)
> Ehsan - thanks for taking a look here.  I believe your patch doesn't address
> comment 6, but that might be its own bug, really.

It is: bug 430074.

Comment 14

[(no longer active)]

(In reply to comment #13)
> It is: bug 430074.

Actually, I think that bug might be a symptom of the same issue as this one, but since it only seems to happen on 3.0.0, and I'm a bit busy working on the private browsing stuff right now, I can't look through it for now, but it should be easy if someone else wants to take a look...

Comment 15

[Serge Gautherie (:sgautherie)]

Comment on attachment 338835 [details] [diff] [review]
Patch (v1)
[Checkin: Comment 15]

http://hg.mozilla.org/mozilla-central/rev/8a1e23e50583

Comment 17

[Marcia Knous [:marcia]]

Verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081013 Minefield/3.1b2pre.

Comment 20

[Bartłomiej Brzozowiec (BartZilla)]

Just info: AFAICT the code related with this bug has been added in unrelated changes in bug 360387.