464106 - compact header view: no S/MIME signature and encryption status indicators displayed

Status: RESOLVED INVALID

(Thunderbird :: Message Reader UI, defect)

Description

[u235898]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.0.3) Gecko/2008092510 Ubuntu/8.04 (hardy) Firefox/3.0.3
Build Identifier: Gecko/20081110 Shredder/3.0b1pre

if detailed headers are shown, correct icons to for SMIME validation (signature) and encryption are shown. If new "normal" header is shown, nothing appears. User is not able to get fast informations about these important informations without switching the headers view-mode.

Reproducible: Always

Steps to Reproduce:
1. receive an signed mail
2. open it
3. switch to normal headers in View-Mode
Actual Results:  
No Icons for SMIME signature / encryption appears for normal headers view

Expected Results:  
some (tiny) icons

Comment 1

[Wayne Mery (:wsmwk)]

Marcel, Is this a regression from Thunderbird 2?

Comment 2

[u235898]

(In reply to comment #1)
> Marcel, Is this a regression from Thunderbird 2?

to my opinion, yes. If there are new features, but relevant - regarding security - features are not available with them, then this is a regression to normal users who are not familiar with "validation" and "signing".

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Yeah, we can't regress this.  Setting blocking+ and regression keyword.

Comment 4

[David :Bienvenu]

dmose, should this be assigned to you, since it has to do with the new headers view, even though it's technically a Mail Window FE bug?

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

If I'm lucky, kaie will be interested in poking at this, but if not, it should be mine, yeah.

Comment 6

[David Ascher (:davida)]

I don't think we have a UI strategy for dealing with this kind of display in the compact view yet.  Throwing to bryan for his take.  Pushing to b3 because I suspect it'll take some iterations to get right.

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

I'm a bit unsure of this, with bug 480623 scheduled to land for b3.  I _am_ on board to make sure the S/MIME sig shows up in the detailed view, though this bug isn't really about that.

Will be pulling some of the good ideas from: http://clarkbw.net/designs/msg-reader/std-msg-reader-w-smime.html

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

Likely I won't be able to move on this until my theme and autoconfig bugs have hit so I'll aim for m3 understanding that I'll likely slip to m4

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

Slipping to m5 with not much hope for making that

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

I can try this weekend to make this happen for the detailed header view, but likely my other work is going to get in the way.

Can someone send me a signed test message?  I don't even have a test piece to work with.

Comment 11

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: WIP for moving the security info into the detailed view list

here's the WIP I have.

This takes the security icon and moves it into the detailed header list view instead of floating off to the right.  In my html earlier mockups I think there can be excellent improvements made that turn this into some simple descriptive text with smaller icons but I'll leave that to another bug.

Comment 12

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: screenshot of smime in the detailed header list view

here's a screenshot of it in action.

Oh and just to note that I didn't localize the 'security' text on purpose as the dtd files for the SMIME properties seem a bit mixed up.  Any tips on where to place the localized label are appreciated or if you want to take this bug over it's all yours.

Comment 13

[Bryan Clark (DevTools PM) [:clarkbw]]

A future implementation could look something like this instead.

<description class="headerValue" onclick="showMessageReadSecurityInfo();">
  <image id="secureHdrIcon"/>
  <label id="sercureHdrLabel"/>
</description>

The #secureHdrIcon can use the same set of ok/broken icons for visually describing the status of the security

#secureHdrLabel could be set to something like the following values:

value="This message was signed by..."
value="This message was encrypted by..."
value="This message was signed and encrypted by..."

Where the "..." could be filled in by the signers name and email.

Comment 14

[Bryan Clark (DevTools PM) [:clarkbw]]

Just noticed I could probably use the sb (small) variants of the existing icons to do what I want.  Might drum up another patch this week and put that up for review to get the strings done.

Comment 15

[Bryan Clark (DevTools PM) [:clarkbw]]

The sb variants are not going to look good.  This likely is going to be a bit of work to get done.  I'm bumping this out to b4 as there is no way this will get enough traction for b3.

My recommendation are:
* use something like described above in comment 13
* get new icons that are 16x16

One possible alteration of what I've been doing would be to give signed and encrypted each it's own header row space.  That would at least give more room to show issues when something was signed incorrectly.

Comment 16

[Dan Mosedale (:dmosedale, :dmose)]

As per <http://weblogs.mozillazine.org/dmose/archives/2009/06/thunderbird_compact_header_mov.html>, the compact header is no longer part of the Thunderbird core, so this bug is no longer valid.