Closed Bug 464313 Opened 13 years ago Closed 13 years ago

don't use method selectors unnecessarily in cursor code

Categories

(Core :: Widget: Cocoa, defect)

Product:
Core
Component:
Widget: Cocoa
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b3

People

(Reporter: jaas, Assigned: jaas)

References

Details

(Keywords: fixed1.9.1)

Attachments

(2 files)

fix v1.0
6.74 KB, patch
smichaud
: review+
roc
: superreview+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
fix v1.0 export
6.00 KB, patch
Details | Diff | Splinter Review
Attached patch fix v1.0 — — Splinter Review 
There are a bunch of places where we use method selectors unnecessarily in cursor code, presumably because when this code was written we supported 10.2 and some cursor methods didn't exist.
Attachment #347589 - Flags: review?(smichaud)
Blocks: 464315
Comment on attachment 347589 [details] [diff] [review]
fix v1.0

Looks fine to me.
Attachment #347589 - Flags: review?(smichaud) → review+
Attachment #347589 - Flags: superreview?(roc)
Attachment #347589 - Flags: superreview?(roc) → superreview+
Comment on attachment 347589 [details] [diff] [review]
fix v1.0

Safe efficiency/cleanup patch, we should take it for 1.9.1.
Attachment #347589 - Flags: approval1.9.1?
Comment on attachment 347589 [details] [diff] [review]
fix v1.0

a191=beltzner
Attachment #347589 - Flags: approval1.9.1? → approval1.9.1+
Attached patch fix v1.0 export — — Splinter Review 
http://hg.mozilla.org/mozilla-central/rev/aadde428c8ce
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.