464315 - make Mac OS X cursor code 64-bit ready

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Josh Aas]

Some key cursor methods in our Mac OS X cursor implementation are not available in 64-bit. We still use Quickdraw's SetCursor function to display many cursors, and we still load an old-style .rsrc file for cursor images.

Comment 1

[Josh Aas]

Attachment: fix v1.0

This makes our cursor code 64-bit safe by removing usage of all APIs that don't exist in 64-bit Mac OS X. It comes with some behavioral changes, some we should fix and others we probably don't need to.

eCursor_wait: This is now just a regular cursor. 64-bit Mac OS X does not provide such a cursor.

eCursor_copy: This is now just a regular cursor. 64-bit Mac OS X does not provide such a cursor.

eCursor_alias: This is now just a regular cursor. 64-bit Mac OS X does not provide such a cursor.

eCursor_context_menu: This is now just a regular cursor. 64-bit Mac OS X does not provide such a cursor.

eCursor_spinning: This is now just a regular cursor. 64-bit Mac OS X does not provide such a cursor.

eCursor_no_drop, eCursor_not_allowed: This is now just a regular cursor. 64-bit Mac OS X does not provide such a cursor.

I'll see what we can do about using custom images for some of these.

Comment 2

[Josh Aas]

Attachment: fix v1.1

This implements "eCursor_wait" and "eCursor_spinning", the most important of the cursors missing in 64-bit Mac OS X. I implemented them using manual animation of Cocoa cursors based on images. Whether or not we should be using these cursors in Firefox any more is another issue.

I think we should take this patch now despite the remaining missing cursors. They aren't critical and we can file separate bugs on implementing them. This patch uses the standard cursor for the missing cursors.

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 356585 [details] [diff] [review]
fix v1.1

I can't review the Makefile changes (I have zero experience with makefiles), but they make sense to me.

+/*! @method     cocoaCursorWithImageNamed:hotSpot:
+ @abstract   Create a Cocoa NSCursor object with a Gecko image resource name and a hotspot point.

Here the alignment is a little wrong.

Other than that, the patch looks good to me.

The old cursorWithFrames method as well as the spinX.tiff images appear to have been unused by Firefox. Are they used by Camino?

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> The old cursorWithFrames method as well as the spinX.tiff images appear to have
> been unused by Firefox. Are they used by Camino?

I know at one time they were, because at one time someone had made a custom spin cursor that was colorized.  However, according to bug 392623, they haven't been since at least 1.9.0; the ones in the .rsrc were overriding the .tiffs instead.

Looks like bug 358159 is now essentially a dupe of this bug, too.

Comment 5

[Josh Aas]

The spinX.tiff images are used in my patch here. They weren't used before. And yes, fixing this will fix 358159.

Comment 6

[Markus Stange [:mstange]]

(In reply to comment #3)
> Here the alignment is a little wrong.

You didn't fix this in your checkin.

Comment 7

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/77cadc513819

Markus, I'll fix that in a followup checkin, sorry.

Comment 8

[philippe (part-time)]

I didn't find any follow-up bug for the missing cursors. I filed bug 489734.

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Looks like this caused 533801.