464417 - Forget About this Site doesn't close open tabs

Status: NEW

(Toolkit :: Data Sanitization, defect, P3)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

STR:

1. Go to www.beltzner.ca/mike
2. History > Show all History
3. Find beltzner.ca and right-click
4. Select "Forget About this Site"

Expected: any tab open with beltzner.ca would close

Actual: abs open with beltzner.ca stay open

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Spun off from bug 464199 comment 2

The following cases must be considered:

 - what happens if closing these tabs ends up closing all the tabs in a window?
 - what happens if closing these tabs ends up closing all open tabs (thus closing the browser on w32)?

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Not blocking as we don't yet have the method being called from the site identity button, and I think that despite Alex's assertion, users will understand a reluctance to close tabs from underneath of one's self.

I do still think this should be fixed, just wouldn't hold the release for it.

Comment 3

[Simon Bünzli]

We still don't have a "Firefox:Browser Glue" component...

Comment 4

[Shawn Wilsher :sdwilsh]

So, I had actually asked about this when I was implementing it, and mconnor had said to leave the tab open.

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

I think all the arguments in favor of clearing history but not the session are based on understanding the implementation model of these things being different.  Also, what is the actual use case for the user saying "do not remember anything about this site, clear everything" and then actually wanting the tabs to still be open?

Comment 6

[Jesse Ruderman]

Closing the tabs might surprise users in a bad way.  How about asking users if they want the tabs to be closed?

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

If 90% of users think clearing history is "removing all evidence" and not "clearing places.sqlite but not sessionstore.js" then I think we should just remove all the evidence.  I honestly can't think of a reason for someone to want to selectively clear everything.  They might find the tab closing surprising the first time, but I don't think the behavior is unwanted, but is actually surprisingly convenient.

Comment 8

[Nochum Sossonko [:Natch]]

(In reply to comment #6)
> Closing the tabs might surprise users in a bad way.  How about asking users if
> they want the tabs to be closed?

As it stands now, if this will cause multiple tabs to close the "Are you sure you want to close n tabs" dialog will popup anyhow, the question is when one tab is closed, should there be a warning? IMHO there should not be, but let's see what ux has to say about that.

Comment 9

[Mike Connor [:mconnor]]

I think I was being conservative, but we should just close the tabs.  We have undo close tab, so unless it's closing a window I think we should just close without asking.

Shawn, make it so? :)

Comment 10

[Jesse Ruderman]

> We have undo close tab

But surely "Forget About this Site" removes sites from this location as well, for privacy reasons?

Comment 11

[Shawn Wilsher :sdwilsh]

(In reply to comment #10)
> But surely "Forget About this Site" removes sites from this location as well,
> for privacy reasons?
probably not...

Comment 12

[Simon Bünzli]

So what about bug 464199?

Comment 13

[Shawn Wilsher :sdwilsh]

(In reply to comment #12)
> So what about bug 464199?
I didn't know about that one.  With this and that, we should be OK (as long as this runs before that)

Comment 14

[Jesse Ruderman]

It seems odd that in other bugs, FAtS goes through lots of trouble to remove local data about the site from hidden places, but in this bug, the proposal is for FAtS to move data from an obvious place (an open tab) to a non-obvious place (the undo close tab list).

I think that when there are tabs for the site open, we should make users click twice: once on a button labeled "close 2 tabs", and then on a button labeled "forget about this site".

Comment 15

[Shawn Wilsher :sdwilsh]

(In reply to comment #14)
> It seems odd that in other bugs, FAtS goes through lots of trouble to remove
> local data about the site from hidden places, but in this bug, the proposal is
> for FAtS to move data from an obvious place (an open tab) to a non-obvious
> place (the undo close tab list).
Bug 464199 also removes it from that non-obvious place, so I'm not sure what the issue is.

Comment 16

[Alex Faaborg [:faaborg] (Firefox UX)]

In the context that this feature is designed to destroy data, we should be more worried about what is preserved as opposed to what is removed.  Since we can't support and undo (without first preserving information), what about a single confirmation prompt that lists how many history visits and open tabs will be cleared.  This has the added benefit of giving us a little more room to describe what is going to happen.

Comment 17

[eyal gruss]

i navigated to an innocent url but the criminating evidence still remained in the tab history (back-forward context menu)
even if we do not close the tab, i think the back-forward context menu should be purged for the offending urls. should i open a new bug for this?

Comment 18

[Mike Beltzner [:beltzner, not reading bugmail]]

Yes, please do.