464721 - Dynamic resizing of all tabs view's thumbnails

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Ed Lee :Mardak]

Attachment: patch against WIP

This is already implemented in Dao's WIP, but what should be the minimum number of columns? I've tweaked the WIP to start showing at 2 columns, and here are some screenshots..

Comment 1

[Ed Lee :Mardak]

Attachment: 2 tabs open

Comment 2

[Ed Lee :Mardak]

Attachment: 3 tabs open

Forgot to mention that this is on my macbook (resolution 1280x800)

Comment 3

[Ed Lee :Mardak]

Attachment: 6 tabs open

Comment 4

[Ed Lee :Mardak]

Attachment: 7 tabs open

Comment 5

[Ed Lee :Mardak]

Attachment: 12 tabs open

Comment 6

[Ed Lee :Mardak]

Attachment: 13 tabs open

Comment 7

[Ed Lee :Mardak]

Attachment: 20 tabs open

Comment 8

[Ed Lee :Mardak]

Attachment: 21 tabs open

Comment 9

[Luke Iliffe (Harlequin99)]

Is this bug the same as Bug 464122? There is a patch over there as well.

Comment 10

[Ed Lee :Mardak]

Attachment: 3 tabs for original WIP

Just for comparison against the current WIP.

Comment 11

[Ed Lee :Mardak]

Attachment: 7 tabs for original WIP

Comment 12

[Ed Lee :Mardak]

Dao, I guess another way to look at this is instead of having a minimum of 6 columns, the minimum is 2.

Comment 13

[Ed Lee :Mardak]

Attachment: 117 tabs open

For Boriss

Comment 14

[Ed Lee :Mardak]

Attachment: 117 tabs open 3:2 aspect ratio

Comment 15

[Dão Gottwald [:dao]]

(In reply to comment #1)
> Created an attachment (id=347986) [details]
> 2 tabs open

So these previews are upscaled, right?

Comment 16

[Dão Gottwald [:dao]]

Comment on attachment 347985 [details] [diff] [review]
patch against WIP

>-    var maxWidth = this._maxWidth - (this.tabCloseButton.boxObject.width || 14) * 2;
>+    var maxWidth = this._maxWidth;

I think what you removed (or something better to replace it) would still be needed, because the padding that REL_BOX_THUMBNAIL adds doesn't necessarily make enough room for the close button. Depends on the theme and the screen resolution.

Comment 17

[Ed Lee :Mardak]

Oh meh. Yeah they are upscaled :p I guess that would be a limiting factor on the minimum number of columns we want to show. Unless we want to dynamically choose the thumbnail resolution depending on how many we need to show.

Yeah I noticed the container box stretching for the close tabs on the rightmost column, but then couldn't we just move the close button in/overlapping the top/right corner?

Comment 18

[Dão Gottwald [:dao]]

(In reply to comment #17)
> Yeah I noticed the container box stretching for the close tabs on the rightmost
> column, but then couldn't we just move the close button in/overlapping the
> top/right corner?

This could cause accidental clicks on the close button when you really want to select a tab, I think.

Comment 19

[Ed Lee :Mardak]

True, but people deal with that when clicking on tabs in the tab bar. You can actually click to the right of the close-tab button and still select the tab.

Another idea is putting the close button next to the text just like it is in the tab bar.

Was putting the text below the image intentional? text above = title, text below = caption.. seems to work either way here.

Comment 20

[Jennifer Morrow [:Boriss] (UX)]

So can we do this with the 3:2 ratio for tabs rather than 16:9?

Comment 21

[Ed Lee :Mardak]

Attachment: aspect ratio = maxWidth / maxHeight on 1200x1920 screen

Comment 22

[Jennifer Morrow [:Boriss] (UX)]

(In reply to comment #21)

Dear god what is that thing

Comment 23

[Jennifer Morrow [:Boriss] (UX)]

And by that I mean we shouldn't be stretching the content to scale it.

Comment 24

[Dão Gottwald [:dao]]

(In reply to comment #20)
> So can we do this with the 3:2 ratio for tabs rather than 16:9?

Yep, that would be a trivial change.

Comment 25

[Ed Lee :Mardak]

Would it be better to just scale it to the same size as the all-tabs box? That's scaled to .9width, .8height. But we need to make sure to scale the thumbnail snapshot to be right as well. I thought I changed ctrlTab.aspectRatio, but it doesn't seem to help?

Comment 26

[Dão Gottwald [:dao]]

The all tabs panel doesn't have a fixed height currently, just a maximum height.

And note that tabPreviews.aspectRatio can't be changed on the fly, you'd need to call init again and throw away already-cached previews.

Comment 27

[Dão Gottwald [:dao]]

Fixed by bug 465076. Note that the previews don't indefinitely, the maximum size is determined by tabPreviews.width (currently screen.availWidth / 5.75).

Comment 28

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Looks good with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b3pre) Gecko/20091110 Namoroka/3.6b3pre ID:20091110034400. Marking verified fixed.

This is covered by Litmus:
https://litmus.mozilla.org/show_test.cgi?id=9162