464758 - <select> with :after content doesn't open

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Simon Bünzli]

Testcase in the URL. Broken in at least in Firefox 3.0 and on Trunk.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is due to the fact that when we reresolve style we detect that there is no generated content, that the style says there should be, so we reframe the whole thing.  I was pretty sure we had a bug on this, but I can't find it.   Of course I was sure there's a bug on us reframing on the generated content thing for replaced elements, and I can't find that either....

David, seems to me it would be nice to have a way to flag frames as needing to skip this check (or alternately needing to do this check) in ReResolveStyleContext.

Comment 2

[rektide]

This also happens if the <select> is contained in a <div> with :after.  Attaching testcase.

Comment 3

[rektide]

Attachment: Test case for div :after

Comment 4

[Boris Zbarsky [:bzbarsky]]

Actually, that's subtly different from this bug as originally reported.  I'm not sure offhand why the issue comes up in that case, and you should probably file a separate bug on it.

Comment 5

[rektide]

Ok I can do that too.  Thanks for the fast reply.  I'll try to get the bug filed tonight, pardon the misfile.

Comment 6

[rektide]

Per your recommendation, I've created a new bug and attached the test case; its locatable at:
https://bugzilla.mozilla.org/show_bug.cgi?id=478310

Comment 10

[Boris Zbarsky [:bzbarsky]]

We have more frame bits now; this should be fixable.

Comment 11

[Seth Borg]

When using element:after { content:"."; } or any other content: except normal, the first click on a SELECT drop down menu field sets the focus. The second click opens the dropdown menu. Tested on IE9 and Chrome 18.0.1025.168 m with no such problems.

<style>
.example:after {
	content:".";
/* below is not really necessary but height:0; makes the period not appear */
	display:block;
	clear:both;
	visibility:hidden;
	height:0;
	overflow:hidden;
}
</style>

<select name="State" class="example">
<option value="">Select</option>
<option value="AL">Alabama</option>
</select>

Comment 12

[Seth Borg]

Note, this is still broken as of Firefox 12

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: Don't try to check for :before/:after pseudos for frames that can't have them.

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 623927 [details] [diff] [review]
Don't try to check for :before/:after pseudos for frames that can't have them.

r=dbaron (though it seems like it might be a waste of a bit)

Also, do you really want to remove the !pseudoTag check (esp. given you're marking all inlines)?

Comment 15

[Boris Zbarsky [:bzbarsky]]

> Also, do you really want to remove the !pseudoTag check (esp. given you're marking all
> inlines)?

Oh, good catch.  I forgot about the inline case.  I'll reinstate the !pseudoTag check.

Comment 16

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6a280a82658

Comment 17

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b6a280a82658