464767 - do not overwrite existing bookmarks if importBookmarksHTML is true but there's no bookmarks.html file

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Dietrich Ayala (:dietrich)]

STR:

1. delete, move or rename bookmarks.html file in the profile directory
2. set the pref browser.places.importBookmarksHTML to true
3. restart

Expected: no changes. we should do nothing if the bookmarks.html file is not present

Actual: all bookmarks are deleted, and the default bookmarks are imported

Comment 1

[Marco Bonardo [:mak]]

notice actually browser.places.importBookmarksHTML is a pref the user has to create (in a new profile) and has to set by himself since we don't do that...

I was thinking that asking that the user could want to import the default... but yes, actually we also have restore_default_bookmarks.... so as you said is better to not do anything and set pref back to false.

Comment 2

[Marco Bonardo [:mak]]

marking as dataloss, i'm thinking to those users that had problems due to importBookmarksHTML set to true and now we could sweep away their bookmarks restoring the defaults.

actually since the patch is low risk i would like to take this followup for b2 if possible

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch

since dietrich is OOTO today asking review to mconnor, let's see if we can take this for b2 as a followup to importBookmarksHTML changes.

Previously when bookmarks.html did not exists we were importing the default bookmarks, but since the two preferences have clear requests (import or restore) we should not.

If the file does not exists we will catch the exception and report the error to the console.

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 348172 [details] [diff] [review]
patch

moving back request to dietrich

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 348172 [details] [diff] [review]
patch

instead of needlessly getting the BMarks reference, please if/else here. also, if importBookmarksHTML is true, and the file doesn't exist, don't bother attempting to import at all.

Comment 6

[Marco Bonardo [:mak]]

Attachment: patch

do you want to differentiate case where default bookmarks.html does not exists? that would be an install/update issue though

Comment 7

[Dietrich Ayala (:dietrich)]

Comment on attachment 348591 [details] [diff] [review]
patch

no, but please report the missing file with Cu.reportError. also, declare bookmarksFile var outside the if/else for clarity.

Comment 8

[Marco Bonardo [:mak]]

Attachment: patch

fixed comments

Comment 9

[Marco Bonardo [:mak]]

Attachment: patch

Comment 10

[Marco Bonardo [:mak]]

Comment on attachment 348626 [details] [diff] [review]
patch

asking approval to land in b2, as a followup to bug 462366, to avoid bookmarks lost.

Comment 11

[Marco Bonardo [:mak]]

Attachment: patch

minor cleanup to code style

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 348628 [details] [diff] [review]
patch

a191b2=beltzner

Comment 13

[Dietrich Ayala (:dietrich)]

http://hg.mozilla.org/mozilla-central/rev/a730d0337646

Comment 14

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv