Closed
Bug 465933
Opened 16 years ago
Closed 16 years ago
"Error: bookmarksFile is undefined" in safe mode when trying to restore default bookmarks
Categories
(Firefox :: Bookmarks & History, defect, P2)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 3.1b3
People
(Reporter: aschultz, Assigned: mak)
References
Details
(Keywords: regression, verified1.9.1)
Attachments
(1 file)
|
1.03 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1b2pre) Gecko/20081120 Minefield/3.1b2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1b2pre) Gecko/20081120 Minefield/3.1b2pre
Error: bookmarksFile is undefined
Source File: file:///net/amun/home/aschultz/bin32/firefox-nightly/components/nsBrowserGlue.js
Line: 515
Reproducible: Always
Steps to Reproduce:
1. enable profile manager on startup
2. start with -save-mode
3. create new profile
4. continue start with newly created profile and stay in -safe-mode
Actual Results:
error console show message:
Error: bookmarksFile is undefined
Source File: file:///home/aschultz/bin32/firefox-nightly/components/nsBrowserGlue.js
Line: 515
|
Assignee | |
Comment 1•16 years ago
|
||
mh i launch Firefox with -profilemanager -safe-mode, i create a new profile, then i choose Continue in safe mode. But i don't see any error. What am i missing from your steps?
Assignee: nobody → mak77
|
Reporter | |
Comment 2•16 years ago
|
||
argh, you are right, i can not repeat it anymore. i think there as a crash during startup involved as well
Status: UNCONFIRMED → RESOLVED
Closed: 16 years ago
Resolution: --- → INVALID
|
|
Assignee | |
Comment 3•16 years ago
|
||
reopening
due to
550 bookmarksFile = dirService.get("profDef", Ci.nsILocalFile)
551 .append("bookmarks.html");
we are not restoring defaults correctly
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
|
|
Assignee | |
Updated•16 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
Assignee | |
Updated•16 years ago
|
Summary: "Error: bookmarksFile is undefined" in safe mode with new profile → "Error: bookmarksFile is undefined" in safe mode when trying to restore default bookmarks
Version: unspecified → Trunk
|
|
Assignee | |
Updated•16 years ago
|
OS: Linux → All
Hardware: PC → All
|
|
Assignee | |
Updated•16 years ago
|
Blocks: 464767
Keywords: regression
|
||
Comment 5•16 years ago
|
||
Comment on attachment 349801 [details] [diff] [review]
patch
r=me. no, this does not need to block b2. should block final though.
Attachment #349801 -
Flags: review?(dietrich) → review+
|
|
||
Comment 6•16 years ago
|
||
this is broken as-is, so should block final.
Severity: minor → normal
Flags: blocking-firefox3.1+
Priority: -- → P2
Target Milestone: --- → Firefox 3.1
|
|
||
Updated•16 years ago
|
Whiteboard: [has patch][has review]
|
|
Assignee | |
Comment 7•16 years ago
|
||
pushed to trunk
http://hg.mozilla.org/mozilla-central/rev/80ebf9e83648
Status: ASSIGNED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•16 years ago
|
Attachment #349801 -
Flags: approval1.9.1?
|
|
Assignee | |
Comment 8•16 years ago
|
||
Comment on attachment 349801 [details] [diff] [review]
patch
asking approval, this is broken, very low risk.
|
|
Assignee | |
Comment 9•16 years ago
|
||
Comment on attachment 349801 [details] [diff] [review]
patch
uh, this is blocking so does not need approval.
Attachment #349801 -
Flags: approval1.9.1?
|
|
Assignee | |
Comment 10•16 years ago
|
||
pushed to 1.9.1 branch:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/22bc0d77148b
Keywords: fixed1.9.1
Whiteboard: [has patch][has review]
Target Milestone: Firefox 3.1 → Firefox 3.1b3
|
||
Comment 11•16 years ago
|
||
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090127 Shiretoko/3.1b3pre
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•