Closed Bug 464909 Opened 11 years ago Closed 6 years ago

test_xtf.js TUnit test has a new leak between 2008-11-13 and -14

Categories

(Core Graveyard :: XTF, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

VERIFIED WONTFIX

People

(Reporter: sgautherie, Assigned: alex)

References

(Blocks 1 open bug, )

Details

(Keywords: memory-leak, regression, Whiteboard: [nsDocument (2), nsXMLDocument (2), etc, leaks])

Attachments

(1 file)

Yesterday, I ran bug 449240 comment 18 which didn't show these leaks.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081114 Minefield/3.1b2pre] (home, optim default) (W2Ksp4)

_tests\xpcshell-simple\test_places\unit
test_nsPIPlacesDatabase_commitPendingChanges.js
(see bug 456414...)

_tests\xpcshell-simple\test_privatebrowsing\unit
test_removeDataFromDomain.js
test_removeDataFromDomain_activeDownloads.js
(see bug 460086...)

_tests\xpcshell-simple\test_xtf\unit
test_xtf.js
(I don't know what caused this one.)
Flags: blocking-firefox3.1?
(In reply to comment #0)
> _tests\xpcshell-simple\test_places\unit
> test_nsPIPlacesDatabase_commitPendingChanges.js
> (see bug 456414...)

bug 463471 !
Dietrich/Marco: over to you
Component: General → Places
QA Contact: general → places
(In reply to comment #0)

> _tests\xpcshell-simple\test_places\unit
> test_nsPIPlacesDatabase_commitPendingChanges.js
> 
> _tests\xpcshell-simple\test_privatebrowsing\unit
> test_removeDataFromDomain.js
> test_removeDataFromDomain_activeDownloads.js

These 3 were fixed by bug 457743.

> _tests\xpcshell-simple\test_xtf\unit
> test_xtf.js

This one remains unchanged.
Assignee: nobody → alex
Component: Places → XTF
Depends on: 457743, 378247
Flags: blocking-firefox3.1?
Product: Firefox → Core
QA Contact: places → xtf
Summary: 4 new TUnit test leaks between 2008-11-13 and -14 → test_xtf.js TUnit test has a new leak between 2008-11-13 and -14
Flags: blocking1.9.1?
Attached file test_xtf.js.log
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b3pre) Gecko/20081128 Minefield/3.1b3pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/2ba4924ee82e)

Fwiw, (nsXTFElementWrapper part of) bug 464067 did not help here.
Whiteboard: [nsDocument (2), nsXMLDocument (2), etc, leaks]
Not blocking on this as this is only a leak in XTF related code, which is extremely rarely used.
Flags: blocking1.9.1? → blocking1.9.1-
(In reply to comment #5)
> Not blocking [...]

I understand your point, yet I would think it's easier to fix this _regression_ sooner rather than later:
proper action is supposed to be to find out the culprit checkin then (fix it or) back it out...
Flags: wanted1.9.1?
Wanted for sure. I don't know that sooner rather than later makes a big difference in this particular case, and I'm afraid it's "later" already.
Flags: wanted1.9.1? → wanted1.9.1+
Depends on: 469523
No longer depends on: 456414
Confirmed by
{
http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1238183877.1238186339.30647.gz&fulltext=1
Linux comm-central check on 2009/03/27 12:57:57
}
OS: Windows 2000 → All
Confirmed by
{
http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird3.0/1238257155.1238260151.7894.gz&fulltext=1
MacOSX 10.4 comm-1.9.1 check on 2009/03/28 09:19:15
}
Flags: wanted1.9.2?
Flags: wanted1.9.1.x?
Hard to say if this is really "wanted" as it's not being worked on for trunk even...
status1.9.1: --- → ?
Flags: wanted1.9.1.x?
status1.9.1: ? → ---
Flags: wanted1.9.2?
XTF has been removed from the tree.  [xtfisdead] for filtering purposes.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
(In reply to Alex Vincent [:WeirdAl] from comment #11)
> XTF has been removed from the tree.

Right, bug 749448 did the removal.

V.WontFix (as in "obsolete").
Status: RESOLVED → VERIFIED
Depends on: 749448
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.