464909 - test_xtf.js TUnit test has a new leak between 2008-11-13 and -14

Status: VERIFIED WONTFIX

(Core Graveyard :: XTF, defect)

Description

[Serge Gautherie (:sgautherie)]

Yesterday, I ran bug 449240 comment 18 which didn't show these leaks.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081114 Minefield/3.1b2pre] (home, optim default) (W2Ksp4)

_tests\xpcshell-simple\test_places\unit
test_nsPIPlacesDatabase_commitPendingChanges.js
(see bug 456414...)

_tests\xpcshell-simple\test_privatebrowsing\unit
test_removeDataFromDomain.js
test_removeDataFromDomain_activeDownloads.js
(see bug 460086...)

_tests\xpcshell-simple\test_xtf\unit
test_xtf.js
(I don't know what caused this one.)

Comment 1

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> _tests\xpcshell-simple\test_places\unit
> test_nsPIPlacesDatabase_commitPendingChanges.js
> (see bug 456414...)

bug 463471 !

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Dietrich/Marco: over to you

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)

> _tests\xpcshell-simple\test_places\unit
> test_nsPIPlacesDatabase_commitPendingChanges.js
> 
> _tests\xpcshell-simple\test_privatebrowsing\unit
> test_removeDataFromDomain.js
> test_removeDataFromDomain_activeDownloads.js

These 3 were fixed by bug 457743.

> _tests\xpcshell-simple\test_xtf\unit
> test_xtf.js

This one remains unchanged.

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: test_xtf.js.log

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b3pre) Gecko/20081128 Minefield/3.1b3pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/2ba4924ee82e)

Fwiw, (nsXTFElementWrapper part of) bug 464067 did not help here.

Comment 5

[Johnny Stenback (:jst)]

Not blocking on this as this is only a leak in XTF related code, which is extremely rarely used.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)
> Not blocking [...]

I understand your point, yet I would think it's easier to fix this _regression_ sooner rather than later:
proper action is supposed to be to find out the culprit checkin then (fix it or) back it out...

Comment 7

[Johnny Stenback (:jst)]

Wanted for sure. I don't know that sooner rather than later makes a big difference in this particular case, and I'm afraid it's "later" already.

Comment 8

[Serge Gautherie (:sgautherie)]

Confirmed by
{
http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1238183877.1238186339.30647.gz&fulltext=1
Linux comm-central check on 2009/03/27 12:57:57
}

Comment 9

[Serge Gautherie (:sgautherie)]

Confirmed by
{
http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird3.0/1238257155.1238260151.7894.gz&fulltext=1
MacOSX 10.4 comm-1.9.1 check on 2009/03/28 09:19:15
}

Comment 10

[Samuel Sidler (old account; do not CC)]

Hard to say if this is really "wanted" as it's not being worked on for trunk even...

Comment 11

[Alex Vincent [:WeirdAl]]

XTF has been removed from the tree.  [xtfisdead] for filtering purposes.

Comment 12

[Serge Gautherie (:sgautherie)]

(In reply to Alex Vincent [:WeirdAl] from comment #11)
> XTF has been removed from the tree.

Right, bug 749448 did the removal.

V.WontFix (as in "obsolete").