464947 - Clear Recent History dialog should clear form data by timespan

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

Bug 463154 added timestamps on form & search history for creation and usage, and Bug 453440 added the concept of removing history for a time range - but neither actually made the new UI obey the user's specified time range.

So right now the UI is broken in ways that will cause dataloss.

Comment 1

[Justin Dolske [:Dolske]]

Eh, I'll finish it up.

Comment 2

[Johnathan Nightingale [:johnath]]

Bacon on, then!

Please also update the existing sanitize-timespan.js test?

Comment 3

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Straightforward patch with gobs of testing.

I caught a bug in the existing sanitizer tests... The |Date| object doesn't have a .year property, so using it was resulting in NaN values. .getFullYear() is what should be used.

Comment 4

[Justin Dolske [:Dolske]]

Also, I think this should be a Beta 2 blocker. Otherwise trying to clear 1 hour of form history results in clearing *all* form history. :(

Comment 5

[Justin Dolske [:Dolske]]

Pushed: http://hg.mozilla.org/mozilla-central/rev/93c324047328

Comment 6

[Marcia Knous [:marcia]]

I am trying to figure out to verify this using SQL Lite Browser. I assume I can check the formhhistory.sqlite to see whether the data is being removed?

Comment 7

[Justin Dolske [:Dolske]]

Yeah, that should work fine.