Closed Bug 464947 Opened 12 years ago Closed 12 years ago

Clear Recent History dialog should clear form data by timespan

Categories

(Firefox :: Preferences, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3.1b2

People

(Reporter: beltzner, Assigned: Dolske)

References

Details

(Keywords: dataloss, fixed1.9.1)

Attachments

(1 file)

Bug 463154 added timestamps on form & search history for creation and usage, and Bug 453440 added the concept of removing history for a time range - but neither actually made the new UI obey the user's specified time range.

So right now the UI is broken in ways that will cause dataloss.
Flags: blocking-firefox3.1+
Eh, I'll finish it up.
Assignee: nobody → dolske
Bacon on, then!

Please also update the existing sanitize-timespan.js test?
Attached patch Patch v.1Splinter Review
Straightforward patch with gobs of testing.

I caught a bug in the existing sanitizer tests... The |Date| object doesn't have a .year property, so using it was resulting in NaN values. .getFullYear() is what should be used.
Attachment #348520 - Flags: review?(mconnor)
Also, I think this should be a Beta 2 blocker. Otherwise trying to clear 1 hour of form history results in clearing *all* form history. :(
Target Milestone: Firefox 3.1 → Firefox 3.1b2
Attachment #348520 - Flags: review?(mconnor) → review+
Keywords: checkin-needed
Whiteboard: [needs landing]
Summary: Clear Recent History dialog should use creation/usage timestamps on form & search history according to specified time range → Clear Recent History dialog should clear form data by timespan
Pushed: http://hg.mozilla.org/mozilla-central/rev/93c324047328
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
I am trying to figure out to verify this using SQL Lite Browser. I assume I can check the formhhistory.sqlite to see whether the data is being removed?
Yeah, that should work fine.
You need to log in before you can comment on or make changes to this bug.