465284 - Open link in new tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement, P1)

Comment 1

[Madhava Enros [:madhava]]

Sounds like an entry in a context-sensitive menu (tap and hold) on a link to me.

Comment 2

[Christian Sejersen]

Agree

Comment 3

[Stuart Parmenter]

I'm not a big fan of piling up stuff in context menus.  Would it make more sense to just allow you to hold a key for this, or do we really need this?

Comment 4

[Jaakko Viitanen]

have a look at the suggested CSM commands and availability from here

https://wiki.mozilla.org/Mobile/UI/Designs/TouchScreen/workingUI/CSM

Comment 5

[Madhava Enros [:madhava]]

Agreed about not just piling stuff into context-sensitive menus, but this is one of the primary uses, in my mind, for a CSM here.  We could use a key, too, but I think we need to design for a keyboard-not-deployed scenario.

Comment 6

[Al Billings [:abillings - ex-MoCo]]

I was going to open a bug on this but I saw this one.

We need a way to open a link in a new tab for usability. Currently, I have to open a new tab from scratch and then browse to the site where I wanted to open a new tab and find the link in question. Compared to Firefox, were people open new tabs from links as a primary use, this is a bit clunky.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

I tend to agree with Al on this issue.  We need to have some method for this, but I think we can prioritize this down.  

Using a CSM seems like the right approach here as it doesn't restrict to devices without keys (like the n800).

Comment 8

[Uwe Kaminski]

In my opinion there are different ways to solve this issue:

1.) Show a menu layer every time I tip on a link. A good example for this is:
http://songza.com/
a.: click on "listen to this playlist now"
b.: click on a song/track
--> Result is an context menu. For fennec it could include "open link in a new tab" and maybe other stuff.

2.) My favorite is the simple tip on the link for a long time and it will open it in a new tab. No context menu. Just tip and hold (~ 2 seconds).

A combination of 1.) and 2.) should be possible too...

3.) First tip on an area in one of the menus (e.g. the tab bar or the sidebar on the right side of the screen...) and then tip on a link.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

While dogfooding Fennec, I find myself wanting this feature a lot.

Comment 10

[Ben Combee (:bcombee)]

We could do this simply on the n900/n810 by using the shift key as a modifier on click.

Comment 11

[Madhava Enros [:madhava]]

If we were going to use a keyboard key as a secondary mechanism (even while we sort out what the primary mechanism is), it's worth looking at Firefox on other platforms.

Mac: Cmd-Click
Win: Ctrl-Click
Linux: Ctrl-Click

Which is apparently <accel>-click.  There's a Ctrl key on the n900's keyboard -- maybe it makes sense to use that one?

Comment 12

[Ben Combee (:bcombee)]

Shift-Click has been used to open in a new window for a while, at least on Windows.  I'd be happy with either combination, since we don't actually support additional Fennec windows.

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

CTRL+click sounds reasonable, since we are opening a new tab. Also multi-key combinations are very hard to do on the devices.

Comment 14

[Dave Royal]

On the N810 CTRL is on the right. If you're right-handed it's much easier to use Fn which is on the left - it's under your thumb.

Make it configurable? Use either?

Comment 15

[Mark Finkle (:mfinkle) (use needinfo?)]

Fn is a sticky key though, so I see that as an accident waiting to happen.

Comment 16

[Mark Finkle (:mfinkle) (use needinfo?)]

CTRL+click will be our Fennec 1.0 approach. No shortcut key is very discoverable, so consistency with desktop Firefox is helpful in this case.

Also, shortcut keys should not be our primary method, but due to time constraints, it might be the only method for Fennec 1.0

Comment 17

[Mark Finkle (:mfinkle) (use needinfo?)]

Ben - are you working on this?

Comment 18

[Ben Combee (:bcombee)]

Yes, I'm trying to get a patch ready before I head on my honeymoon.

Comment 19

[Ben Combee (:bcombee)]

Attachment: Part 1: propogate shift key flags to content on clicks

This is the first part of the fix -- get shift/ctrl/alt/meta status passed into content when we send a click event

Comment 20

[Ben Combee (:bcombee)]

Attachment: Full patch for ctrl-click opening new tab

This is a full patch.  We're not adding click handler to content, just doing it before we'd dispatch to content.  It worked on planet.mozilla.com, and ctrl-click on non-links did nothing.  Right now, it opens in new tab with no UI indicating the change, could easily modify to open in background if we could popup notification about new tab being created.

Comment 21

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 407695 [details] [diff] [review]
Full patch for ctrl-click opening new tab

Nice, simple patch. Before I r+, I want to talk to Madhava about the background vs. foreground issue (I'm leaning on background, but we'll see)

I might throw some explicit element type checks in the getHrefForElement method too. Just in case some yahoo puts "href" on atypical elements.

Thanks and have fun on the honeymoon!

Comment 22

[Madhava Enros [:madhava]]

Background.  That's what we do on the desktop, and I think that makes sense here too.

Comment 23

[Ben Combee (:bcombee)]

I'll adjust code for opening in background and also update the href detection code.  Not sure how to do the notifications yet, I'll leave that for someone else.

Comment 24

[Madhava Enros [:madhava]]

I believe that the notification for background tabs happens because of existing code?  But, then, I believe a lot of things.

Comment 25

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #24)
> I believe that the notification for background tabs happens because of existing
> code?  But, then, I believe a lot of things.

You are correct. Popup should just work.

Comment 26

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/f24c33089482

with changes for opening in background and matching FF link-find code

Comment 27

[Mark Finkle (:mfinkle) (use needinfo?)]

NOTE: Bug 524123 means the opened tab does not render correctly. Not related to this bug/patch

Comment 28

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091026
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091026
Fennec/1.0b5pre

Comment 29

[Al Billings [:abillings - ex-MoCo]]

In-litmus+

https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=9764