465566 - pretxnchangegroup.a_treeclosure rejected a push to my user repo

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Edwin Smith]

pushing a brand new (no parent) change to an empty repo at http://hg.mozilla.org/users/edwsmith_adobe.com/nanojit-tamarin, got this error:

remote: Unrecognized tree!  I don't know how to check closed status for nanojit-tamarin.
remote: transaction abort!
remote: rollback completed
remote: abort: pretxnchangegroup.a_treeclosure hook failed
abort: unexpected response: empty string

Comment 1

[Johnathan Nightingale [:johnath]]

Hmm - this should only have been added for mozilla-central.  Aravind?

Comment 2

[Steven Johnson]

ditto for tamarin-redux

Comment 3

[Justin Wood (:Callek)]

bumping to major... I think this is the least obstructive, but does ping, mode for IT

Comment 4

[Aravind Gottipati [:aravind]]

Oh.. the script had a mapping like 
    'mozilla-central': 'http://tinderbox.mozilla.org/Firefox/',
    'comm-central'   : 'http://tinderbox.mozilla.org/Thunderbird/',
    'mobile-browser' : 'http://tinderbox.mozilla.org/Mobile/'

So I assumed it'd check the repo name against a tinderbox tree status, and that the default would allow checkins.


Moving it to mozilla-central only.

Comment 5

[(not currently active) Ted Mielczarek]

Sorry, we should have been more clear on that. Our intent is that this will be strictly opt-in per repository.

Comment 6

[Edwin Smith]

no problem.  Just pushed successfully.

Comment 7

[Johnathan Nightingale [:johnath]]

Yeah, I should have called that out more too - the mappings are there as an illustration, so that when mozilla-random wants to opt-in here, they can add a mapping for their tree, and then hook this to their tree.

On the plus side - it failed in the way it was supposed to, so we detected bad hooks early.  :)