Closed
Bug 465731
Opened 16 years ago
Closed 11 years ago
Don't include toolbar.css in application chrome
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 23.0
People
(Reporter: jminta, Assigned: mkmelin)
References
Details
Attachments
(1 file, 1 obsolete file)
13.62 KB,
patch
|
bwinton
:
review+
|
Details | Diff | Splinter Review |
After bug 404229, we don't need toolbar.css just to make our buttons work. See also http://hg.mozilla.org/mozilla-central/rev/2686d82a880c
Attachment #348973 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Comment 1•16 years ago
|
||
Comment on attachment 348973 [details] [diff] [review] patch v1 Looks good to me, r=mkmelin
Attachment #348973 -
Flags: review?(mkmelin+mozilla) → review+
Comment 2•16 years ago
|
||
Except that bug 404229 got backed out and denied the right to get back into 1.9.1.
Reporter | ||
Comment 3•16 years ago
|
||
Bummer, guess I won't be landing this for awhile.
Depends on: 404229
Comment 4•11 years ago
|
||
(In reply to Phil Ringnalda (:philor) from comment #2) > Except that bug 404229 got backed out and denied the right to get back into > 1.9.1. landed in 2009. so this patch can land, if still needed.
Flags: needinfo?(mkmelin+mozilla)
Assignee | ||
Comment 5•11 years ago
|
||
Needless to say, the patch had severely bitrotted, but this should be it.
Assignee: jminta → mkmelin+mozilla
Attachment #348973 -
Attachment is obsolete: true
Attachment #726313 -
Flags: review?(bwinton)
Flags: needinfo?(mkmelin+mozilla)
Comment 6•11 years ago
|
||
Comment on attachment 726313 [details] [diff] [review] proposed fix It has bitrotted again, but a little "%s/gnomestripe/linux/g", etc has fixed it up, and so it's that version that I'll review. > find mail/themes/ -type f -exec sed -i '/@import url("chrome:\/\/global\/skin\/toolbar.css");/d' {} \; Hmm. I wonder if it would have been easier to just re-run this instead of patching the diff? :) Anyways, it does what it says on the box, and doesn't seem to break anything. r=me, for the de-bitrotted version. Thanks, Blake.
Attachment #726313 -
Flags: review?(bwinton) → review+
Assignee | ||
Comment 7•11 years ago
|
||
http://hg.mozilla.org/comm-central/rev/e5d09a5e78c0 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
You need to log in
before you can comment on or make changes to this bug.
Description
•