Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Don't include toolbar.css in application chrome

RESOLVED FIXED in Thunderbird 23.0

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
9 years ago
4 years ago

People

(Reporter: Joey Minta, Assigned: Magnus Melin)

Tracking

Trunk
Thunderbird 23.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

13.62 KB, patch
bwinton
: review+
Details | Diff | Splinter Review
(Reporter)

Description

9 years ago
Created attachment 348973 [details] [diff] [review]
patch v1

After bug 404229, we don't need toolbar.css just to make our buttons work. See also http://hg.mozilla.org/mozilla-central/rev/2686d82a880c
Attachment #348973 - Flags: review?(mkmelin+mozilla)
(Assignee)

Comment 1

9 years ago
Comment on attachment 348973 [details] [diff] [review]
patch v1

Looks good to me, r=mkmelin
Attachment #348973 - Flags: review?(mkmelin+mozilla) → review+
Except that bug 404229 got backed out and denied the right to get back into 1.9.1.
(Reporter)

Comment 3

9 years ago
Bummer, guess I won't be landing this for awhile.
Depends on: 404229

Updated

9 years ago
Blocks: 479674

Updated

9 years ago
No longer blocks: 479674
(In reply to Phil Ringnalda (:philor) from comment #2)
> Except that bug 404229 got backed out and denied the right to get back into
> 1.9.1.

landed in 2009. so this patch can land, if still needed.
Flags: needinfo?(mkmelin+mozilla)
(Assignee)

Comment 5

4 years ago
Created attachment 726313 [details] [diff] [review]
proposed fix

Needless to say, the patch had severely bitrotted, but this should be it.
Assignee: jminta → mkmelin+mozilla
Attachment #348973 - Attachment is obsolete: true
Attachment #726313 - Flags: review?(bwinton)
Flags: needinfo?(mkmelin+mozilla)
Comment on attachment 726313 [details] [diff] [review]
proposed fix

It has bitrotted again, but a little "%s/gnomestripe/linux/g", etc has fixed it up, and so it's that version that I'll review.

> find mail/themes/ -type f -exec sed -i '/@import url("chrome:\/\/global\/skin\/toolbar.css");/d' {} \;

Hmm.  I wonder if it would have been easier to just re-run this instead of patching the diff?  :)

Anyways, it does what it says on the box, and doesn't seem to break anything.  r=me, for the de-bitrotted version.

Thanks,
Blake.
Attachment #726313 - Flags: review?(bwinton) → review+
(Assignee)

Comment 7

4 years ago
http://hg.mozilla.org/comm-central/rev/e5d09a5e78c0 -> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 23.0
You need to log in before you can comment on or make changes to this bug.