465746 - Marking bugs duplicate got a lot more annoying

Status: VERIFIED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is a regression from yesterday's update.

STEPS TO REPRODUCE:
1) Load an unresolved bug.
2) Decide to mark it a duplicate.
3) Click the "edit" link next to the status near the top

EXPECTED RESULTS: Some way to mark it as duplicate

ACTUAL RESULTS: Nothing in sight to do that.  Have to scroll down to find the right link.

DETAILS: The "edit" link has an href of #bug_status_bottom, and if that's all it did life would be fine.  Browsers scroll to put the target anchor as near the top of the viewport as possible, so the "mark as duplicate" link would be visible.  However the anchor _also_ has an onclick handler which focuses the element with id bug_status and then prevents the anchor navigation.  When focusing a control browsers scroll as little as possible to put the control in the viewport.  In this case that means not showing the "mark as duplicate" link.

I suggest removing the "return false" in that onclick handler.

Comment 1

[Frédéric Buclin]

You don't need the "Mark as duplicate" link to do so. Just set the bug status to RESOLVED and the resolution to DUPLICATE. The dup ID field will automatically appear. The link above is just a helper.

Comment 2

[Boris Zbarsky [:bzbarsky]]

While true, that's more clicks....

Comment 3

[Frédéric Buclin]

Workaround for now: if Firefox includes links when you click Tab, you can do the following:

1. Click "edit"
2. Press Tab
3. Press Enter

This will set the bug to RESOLVED DUPLICATE and the dupe ID field will appear.

Comment 4

[Max Kanat-Alexander]

Yeah, I agree this should be fixed. Actually, we should move to the additional comments anchor and then focus the status box.

Comment 5

[Frédéric Buclin]

(In reply to comment #4)
> Yeah, I agree this should be fixed. Actually, we should move to the additional
> comments anchor and then focus the status box.

Oh please no. I like the current behavior because I can still see a large part of the form while editing the bug status. That was the reason why pyrzak replaced the link to the anchor by the focus IIRC.

Comment 6

[Boris Zbarsky [:bzbarsky]]

See a large part of what form?  For a typical Mozilla bug, all you can see is the "Additional Comments" field and the last 2-3 comments....

Comment 7

[Max Kanat-Alexander]

And if you have the comment box at the top, really all you can see is the attachments and then the comment box. I'm going to have to disagree on comment 5 and agree with Boris and myself, on this one.

Comment 8

[Frédéric Buclin]

(In reply to comment #6)
> See a large part of what form?

I have the "Additional Comment" box at the top, and I currently see everything from the target milestone + Flags and below.


(In reply to comment #7)
> I'm going to have to disagree on comment
> 5 and agree with Boris and myself, on this one.

It doesn't mean anything to agree with "yourself". I guess everyone agrees with himself. So that's a pretty weak reason to disagree with what I'm experiencing.

Comment 9

[Frédéric Buclin]

Also, if you have your comment box at the end of the bug, you could as well press "Page Down" to directly jump to the bottom of the page. Your "Mark as duplicate" link would immediately be visible.

Comment 10

[Max Kanat-Alexander]

(In reply to comment #8)
> I have the "Additional Comment" box at the top, and I currently see everything
> from the target milestone + Flags and below.

  Yeah, I see less than that (Assignee and below), but only with no attachments and with a maximized browser window on my 1680x1050 monitor.

  In any case, it was very confusing to me when I first clicked "edit" next to the Status and it appeared and the very, very bottom of the page, so we need to focus it in another way that's less confusing, and also allows access to the bits below it.

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

What about just moving the "Mark as Duplicate" link to the left of (and therefore on the same line as) the status <select>?

That should fix things for any UI arrangement, right, still be visible when jumping from the "edit" link at the top of the page (no changes to where we scroll), and not require changing what element is focused; I *think* that makes everyone here happy? Or do people want the "Commit" button to be in view, too?

Comment 12

[Boris Zbarsky [:bzbarsky]]

That last would be nice, yes... ;)

Comment 13

[Guy Pyrzak]

I might as well mention that the solution mentioned in comment 11 will cause the Mark as Duplicate link to jump around from left to right (if it is on left it might even be more confusing, but eh). Also for those of you who complain about clicking, tab followed by an enter is much more efficient than trying to click the link and faster. Also please see bug 464732, bugzilla's head and mozilla once it updates will both have that change. Not sure it affects anything. 

Also the focus was max's idea, not mine, give credit where it is due.

Comment 14

[Max Kanat-Alexander]

(In reply to comment #13)
> Also the focus was max's idea, not mine, give credit where it is due.

  For sure, it was me. :-)

Comment 15

[Max Kanat-Alexander]

Attachment: v1

Okay, here's my fix for it.

Comment 16

[Guy Pyrzak]

Comment on attachment 349243 [details] [diff] [review]
v1

looks fine to me

Comment 17

[Max Kanat-Alexander]

tip:

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.140; previous revision: 1.139
done

3.2:

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.125.2.13; previous revision: 1.125.2.12
done

Comment 18

[Frédéric Buclin]

Attachment: Screenshot

With this patch, the Commit button is now too far on the right IMO. This really looks wrong to me.

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks, that's much better now. Verified.