465811 - [silme] extend list of objects with a "uri" attribute

Status: RESOLVED FIXED

(Mozilla Localizations :: Infrastructure, defect)

Description

[Adrian Kalla [:adriank]]

Attachment: patch adding 'uri' value to L10nPackages created through getL10nPackages() in io.file.py

Based on a discussion with Gandalf: it would be useful to have the same attribute behavior in all objects which can repesent files or folders.

L10nPackages do have the "uri" attribute, but getL10nPackages() in io.file.py does not set it.


At the moment all of the following diff-objects: EntityListDiff, ObjectDiff, L10nObjectDiff, L10nPackageDiff do not have it.
Adding the uri attribute to them requires us to save both uris. I solved this by saving them in a tuple.

Comment 1

[Adrian Kalla [:adriank]]

Attachment: patch adding 'uri' to diff-objects

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 349031 [details] [diff] [review]
patch adding 'uri' to diff-objects

cool. both patches are good. I'd prefer to use first self.uri then remote object uri in tuples.
Can you update the patch please?

Comment 3

[Adrian Kalla [:adriank]]

Attachment: patch adding 'uri' to diff-objects (v2)

changed order of uris in tuples

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 349141 [details] [diff] [review]
patch adding 'uri' to diff-objects (v2)

sweet :)

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

fixed, commited