Closed Bug 465811 Opened 14 years ago Closed 14 years ago

[silme] extend list of objects with a "uri" attribute

Categories

(Mozilla Localizations :: Infrastructure, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: adriank, Assigned: adriank)

References

Details

Attachments

(2 files, 1 obsolete file)

Based on a discussion with Gandalf: it would be useful to have the same attribute behavior in all objects which can repesent files or folders.

L10nPackages do have the "uri" attribute, but getL10nPackages() in io.file.py does not set it.


At the moment all of the following diff-objects: EntityListDiff, ObjectDiff, L10nObjectDiff, L10nPackageDiff do not have it.
Adding the uri attribute to them requires us to save both uris. I solved this by saving them in a tuple.
Comment on attachment 349031 [details] [diff] [review]
patch adding 'uri' to diff-objects

cool. both patches are good. I'd prefer to use first self.uri then remote object uri in tuples.
Can you update the patch please?
changed order of uris in tuples
Attachment #349031 - Attachment is obsolete: true
Attachment #349141 - Flags: review?(gandalf)
Comment on attachment 349141 [details] [diff] [review]
patch adding 'uri' to diff-objects (v2)

sweet :)
Attachment #349141 - Flags: review?(gandalf) → review+
fixed, commited
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.