465822 - fashionyourfirefox.com does not detect Fedora Linux's flavor of Firefox 3

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[m]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.0.4) Gecko/2008111217 Fedora/3.0.4-1.fc9 Firefox/3.0.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.0.4) Gecko/2008111217 Fedora/3.0.4-1.fc9 Firefox/3.0.4

When I try to install Fashion Your Firefox addon, it suggest upgrading to Firefox 3. Probably incorrectly detects version number, see screenshot attached.

Reproducible: Always

Steps to Reproduce:
1. open firefox
2. type fashionyourfirefox.com 

Actual Results:  
website claims I am not using firefox 3

Expected Results:  
browser version should be correctly detected, if platform is not compatible, there should be the message “incompatible platform” but not misleading information.

Comment 1

[m]

Attachment: Firefox 3.0 or not Firefox 3.0?

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of Firefox 3.0.4 in Ubuntu 8.04

Probably a Fedora-specific issue with their UA.

Comment 3

[m]

as you can see in the bug description above Fedora adds “Fedora/3.0.4-1.fc9” to the UA, but does not remove “Firefox/3.0.4” - so I guess it should not affect browser detection.

Comment 4

[Fred Wenzel [:wenzel]]

I can confirm the problem, however, I am trying to figure out if we need to push this upstream: jQuery's $.browser.version returns the *Gecko* version (1.9something) for Firefox, but in the case of Fedora's Firefox build, it returns "3.0.4", i.e., the *Firefox* version. I am currently unable to tell who is at "fault" here, jQuery or Fedora.

Rey: Can you tell who we should consult about this at jQuery?


Nonetheless, for the purposes of *this* bug, I fixed it in r20079.

Comment 5

[Fred Wenzel [:wenzel]]

Reducing severity, it's not a general Linux incompatibility. I'll keep this open for now, until we've figured out if we need to push this upstream.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Marek: would you mind double-checking, post-fix, on https://preview.addons.mozilla.org/en-US/firefox/collections/interactive in about 20 minutes?

Comment 7

[m]

Works :) Thanks!

Comment 8

[Dave Garrett]

(In reply to comment #4)
> Nonetheless, for the purposes of *this* bug, I fixed it in r20079.

if (uamatch == null | uamatch[1].substr(0,1)!="3") {

You used a bitwise OR instead of a boolean OR; you're missing a pipe.

Comment 9

[Fred Wenzel [:wenzel]]

(In reply to comment #8)
> You used a bitwise OR instead of a boolean OR; you're missing a pipe.

Thanks for paying so much attention :) I noticed it immediately and already fixed this about a minute after I initially checked it in; that was a typo :(

Comment 10

[Fred Wenzel [:wenzel]]

jresig: Can you comment on comment 4? Is this a bug in jQuery?

Comment 11

[John Resig]

It sounds like a jQuery problem. You should submit a ticket to the bug tracker: http://dev.jquery.com/ - hopefully with a patch as well.

Comment 12

[Fred Wenzel [:wenzel]]

I pushed this bug upstream: http://dev.jquery.com/ticket/3696

Marking this fixed.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED per Marek's comment 7.