folder pane context open menu item doesn't open correctly

RESOLVED FIXED in Thunderbird 3.0b1

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

Trunk
Thunderbird 3.0b1
x86
Windows XP
Bug Flags:
blocking-thunderbird3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

10 years ago
If I do a folder pane context menu open command, it opens a new window, but in the wrong folder view (favorites instead of all). That's with a partial patch that fixes other issues...
Flags: blocking-thunderbird3+
(Assignee)

Comment 1

10 years ago
Created attachment 349070 [details] [diff] [review]
proposed fix

this takes the interesting parts of the folder pane columns patch, and adds the removal of the prefs from all-thunderbird.js. Now, we remember the last view used, and open in new window works.
Attachment #349070 - Flags: review?(jminta)
(Assignee)

Comment 2

10 years ago
Created attachment 349074 [details] [diff] [review]
correct patch
Attachment #349070 - Attachment is obsolete: true
Attachment #349074 - Flags: review?(jminta)
Attachment #349070 - Flags: review?(jminta)
(Assignee)

Comment 3

10 years ago
Created attachment 349081 [details] [diff] [review]
don't get rid of folder version

jminta correctly points out that we can't get rid of folder version pref because that will break migration from 1.5
Attachment #349074 - Attachment is obsolete: true
Attachment #349081 - Flags: review?(jminta)
Attachment #349074 - Flags: review?(jminta)

Comment 4

10 years ago
Comment on attachment 349081 [details] [diff] [review]
don't get rid of folder version

+          if (gFolderTreeView._rowMap.length)
+            gFolderTreeView.selectFolder(gFolderTreeView._rowMap[0]._folder);
+         }
The closing brace looks poorly aligned.

I'm not wild about reviewing my own code, but if you can't find someone else with a spare 15 minutes, r=jminta
Attachment #349081 - Flags: review?(jminta) → review+

Comment 5

10 years ago
Note also that this'll create the slightly unintuitive result that the second window will be opened with the persisted open-map from the last restart, rather than the current open-map. We might want to flush the json to disk before opening, or come up with a way to pass the open-map to the new window.
(Assignee)

Comment 6

10 years ago
well, for the part you did, you're just reviewing that I didn't mess up extracting the patch. I'll put us down as both reviewing it...
(Assignee)

Updated

10 years ago
Whiteboard: will checkin when tree is open
(Assignee)

Comment 7

10 years ago
fix checked in - this will also fix bug 465267
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Blocks: 465267
Whiteboard: will checkin when tree is open
You need to log in before you can comment on or make changes to this bug.