Closed
Bug 465859
Opened 16 years ago
Closed 16 years ago
[silme] Entity.getValue() crashes on empty fallback list
Categories
(Mozilla Localizations :: Infrastructure, defect)
Mozilla Localizations
Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: adriank, Assigned: adriank)
References
Details
Attachments
(1 file, 2 obsolete files)
|
3.65 KB,
patch
|
zbraniecki
:
review+
|
Details | Diff | Splinter Review |
silme.core.entity.Entity.getValue() crashes if it gets an empty list as fallback. Unfortunately: that's exactly the default value for L10nObjects and EntityLists.
I think there are two ways of fixing this problem:
1) check for empty lists in Entity.getValue() (like in the attached patch)
2) change the default value of L10nObject.fallback and EntityList.fallback from "[]" to "None"
|
||
Comment 1•16 years ago
|
||
I think I prefer L10nObject.fallback=None patch :)
|
Assignee | |
Comment 2•16 years ago
|
||
Attachment #349091 -
Attachment is obsolete: true
Attachment #349269 -
Flags: review?(gandalf)
|
|
Assignee | |
Updated•16 years ago
|
Attachment #349269 -
Attachment is obsolete: true
Attachment #349269 -
Flags: review?(gandalf)
|
|
Assignee | |
Comment 3•16 years ago
|
||
changing "L10nObject.fallback=[]" to "L10nObject.fallback=None" results in crashes. I'll need to investigate more to find a good solution for that problem.
|
|
Assignee | |
Comment 4•16 years ago
|
||
this patch works without crashes
|
|
||
Updated•16 years ago
|
Attachment #349507 -
Flags: review?(gandalf) → review+
|
|
||
Comment 5•16 years ago
|
||
Comment on attachment 349507 [details] [diff] [review]
change default fallback values and adjust parsers for that change
good
|
|
||
Comment 6•16 years ago
|
||
commited
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•