465867 - [silme] make sure Silme works on Windows

Status: RESOLVED FIXED

(Mozilla Localizations :: Infrastructure, defect)

Description

[Adrian Kalla [:adriank]]

Before we ship we have to make sure that Silme works on Windows too. 
Silme seems to work with compare-locales on Windows, but compare-locales is using maybe only 20-30% of the Silme API.
In some Silme methods I see "path.split('/')" or "'/'.join(path[1:])" -> that obviously cannot work with Windows.

I think we should use this bug as a tracking bug for Windows problems.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

right. I'll test it after setting up environment on Windows.

It is blocking release, but it should happen after PEP08 and documentation.

Comment 2

[Axel Hecht [:Pike]]

IIRC, windows does accept '/' as path separator.

This might be a problem with argument parsing, though.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Installed silme and prepared environment on Windows. Documented it here: http://wiki.braniecki.net/Silme:Tutorial:Setting_up_environment

Tested all unittests successfully.

Will now investigate path.split and .join(path cases

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Whoa!!!!

We're good on Windows!

So, both, split and join are used in two ways:

1) In a "good" way from the "no OS discrimination" standpoint (like os.path.join(dir, file))
2) In a "bad" way from that standpoint (like path.split('/'))

but the second case happens only wrt internal paths.

It means that all the paths that touch file system are system dependent, and the paths that we use internally like:
 - l10npack.get_element('pack/pack2/object')
 - l10npack_add_object(l10nobject, path='pack/pack2/object')

are hardcoded with '/' which makes total sense because this is our virtual file system inside package container and we can traverse it according to our methods.

So I call this bug closed and if anyone finds something that doesn't work, file a new bug please!