465968 - MailNews leak & bloat runtest.py needs to work for other apps than just Thunderbird

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Mark Banner (:standard8)]

I just realised that runtest.py is Thunderbird specific, we need to adapt it so it'll work with SeaMonkey as well (especially as I asked for nye to start running with runtest.py).

I think the simplest way to do this, would be to pass it an extra argument we need:

binary name (e.g. thunderbird or seamonkey, we know about the -bin for appending)
brand name & debug (e.g. ShredderDebug, Shredder, SeaMonkey, SeaMonkeyDebug, Thunderbird, ThunderbirdDebug).

I'm not sure if our buildbot configs know about these or not, but I suspect we can just hard code them into the prefs.

Thoughts?

Comment 1

[Philippe M. Chiasson (:gozer)]

Our buildbots know about these, so it wouldn't be a problem to pass these in as arguments, i.e.

$> python runtests.py --bin=thunderbird --brand=Shredder

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

Add arguments as suggested in comment 1. Note that we'll need to use 'ShredderDebug' as the argument to pass to -brand.

Comment 3

[Philippe M. Chiasson (:gozer)]

Comment on attachment 349978 [details] [diff] [review]
The fix

So this becomes:

$> python mailnews/[...]/runtests.py --bin=thunderbird --brand=ShredderDebug --objdir=objdir-tb

? --debug-brand maybe? There is something about brand=...Debug that's going to get me confused at some point.

Also, could this default to the current behaviour (i.e. thunderbird as the default binary name) so as not to break current buildbot when this is landed ?

Comment 4

[Mark Banner (:standard8)]

Attachment: [checked in] The fix v2

With debug/release options and defaulting to the current TB setup.

Comment 5

[Philippe M. Chiasson (:gozer)]

Comment on attachment 350147 [details] [diff] [review]
[checked in] The fix v2

I very much like the --release option as well.

Comment 6

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/e8e722742c70

Comment 7

[Andrew Schultz]

FYI, this is a big help for SeaMonkey, but when running the script, it just opens the browser window because it doesn't pass -mail.  The test seems to work with that hacked in, but I'm not sure of the best way to make that happen correctly.

Comment 8

[Philippe M. Chiasson (:gozer)]

adding support for some --extra-stratup-args="--mail" argument maybe ?

Comment 9

[Mark Banner (:standard8)]

Attachment: [checked in] Add extra option

Adds an extra option so you can do:

--extra-startup-arg="--mail"

This only works for one argument. I think that's enough for now, we can extend the script later if we want more.

Comment 10

[Andrew Schultz]

Comment on attachment 350756 [details] [diff] [review]
[checked in] Add extra option

r=me.  looks OK for now and does work.

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 350756 [details] [diff] [review]
[checked in] Add extra option

http://hg.mozilla.org/comm-central/rev/ffff22bd6021