466095 - Text description still appears after task is deleted

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[lino]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b1) Gecko/20081007 Firefox/3.1b1
Build Identifier: Thunderbird version 2.0.0.18 (20081105)

check that there are no task created
create new task in calendar view (right side) and add some text to the task
delete the task (right-button mouse and delete task)
switch to task view (left down)
the deleted task text, is still in the lower-panel

Reproducible: Always

Steps to Reproduce:
1.check that there are no task created
2.create new task in calendar view (right side) and add some text to the task
3.delete the task (right-button mouse and delete task)
4.switch to task view (left down)
5.the deleted task text, is still in the lower-panel
Actual Results:  
The description text of the task keep's appearing in the description location, but the task was deleted.

Expected Results:  
No text should appear

It is more than cosmetic than a real problem. But if I delete a task, I don't want that text to stay in the description box. It's a bug, but a minor bug.

Comment 1

[Daniel Boelzle [:dbo]]

Same problem as Berend works on bug 404039? The tree's observer is not registered. Adding dependency so we could check once it's fixed.

Comment 2

[Canis Lupus Campestris]

The same problem with last nightly build.
What about 1.0 to fix it?

Comment 3

[Andreas Treumann]

Checked in lightning build 20081218, reproducible also with Linux and MAC

Comment 4

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Attachment: Fix - v1

Comment 5

[Berend Cornelius]

Comment on attachment 357790 [details] [diff] [review]
Fix - v1

>+          let index = tree.currentIndex;
>+          if (tree.view && tree.view.selection) {
>+              // If the current index is not selected, then ignore
>+              index = (tree.view.selection.isSelected(index) ? index : -1);
>+          }

I think this implementation should be within the property implementation of "currentIndex", shouldn't it?
r=berend

Comment 6

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

No, currentIndex is (see nsITreeSelection) the node that has is marked active (i.e has a dotted line around it). This does not mean its selected (i.e the item is highlighted.

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/28e654cdf8e6>

-> FIXED

Comment 7

[Berend Cornelius]

in reply to comment #6:
But then "currentTask" should also refer to the active task and not to the selected.  When I look at the code again I see that there is even a "selectedTasks" property that you could have used as well.

Comment 8

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

I didn't want *all* selected tasks, but the currently active task that is selected. I don't think it makes sense to display the task information when it is not selected. I don't really mind though, do you really think we should change this back?

Comment 9

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".