466162 - Requesting a link to editor tools in page header when logged in with editor privileges

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, enhancement)

Description

[John Ford [:jhford] CET/CEST Berlin Time]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.4) Gecko/2008111217 Fedora/3.0.4-1.fc10 Firefox/3.0.4
Build Identifier: addons.mozilla.org that was in production 2008-11-21

I am an editor for AMO.  After I have logged in, I see underneath "Welcome John" in the right side I have links to "Developer Tools" and "Editor Tools".  I also have links to "My Account", "Developer Tools" and "Log Out".  Is there any way to also have "Editor Tools" when I am logged into an account with editor privileges?

This isn't a huge deal, but it would be nice to have.  I will look into writing a patch if it works.

Reproducible: Always

Steps to Reproduce:
1. Log in as an editor
Actual Results:  
links for "My Account | Developer Tools | Log out" are shown

Expected Results:  
links for "My Account | Editor Tools | Developer Tools | Log out" are shown

I manually edited the source for various pages and everything fit for me and looked fine.
This is what I inserted in the generated page source.

<li><a href="/en-US/firefox/users/edit"  title="[e-mail]">My Account</a></li>

<li><a href="/en-US/developers" >Developer Tools</a></li>

<li><a href="/en-US/editors" >Editor Tools</a></li>

<li><a href="/en-US/firefox/users/logout?to=en-US%2Ffirefox" >Log out</a></li>

Comment 1

[Wil Clouser [:clouserw]]

Attachment: add menu

This bugs me too so I wrote a patch.  It's kind of ugly but you'll only see all the options if you have all the permissions so I don't think it's a big deal.  What do you think?

Comment 2

[Wil Clouser [:clouserw]]

Attachment: screenshot after patch

Here is a screenshot.  Also, the RTL CSS will need some work before we can land this.

Comment 3

[u278084]

Attachment: patch in rtl language

I think it looks good. It brought a smile to my face when I saw that 'Localizer Tools' was the only sidebar menu we didn't localize.

The attached screenshot looks good. From right-to-left, it's My account, developer tools, editor tools, localizer tools, admin tools, and logout. Not sure what it should be :)

Comment 4

[Wil Clouser [:clouserw]]

That's not what it looked like when I previewed RTL or I would have just committed.  In mine the words were under the Firefox logo.  Did you tweak the code?

Comment 5

[u278084]

(In reply to comment #4)
> That's not what it looked like when I previewed RTL or I would have just
> committed.  In mine the words were under the Firefox logo.  Did you tweak the
> code?

Nope. Did a svn revert, and looks clean.

Comment 6

[Wil Clouser [:clouserw]]

Attachment: rtl screenshot

This is what I see

Comment 7

[u278084]

ok. I got what you got under a new profile. So my mistake.

Comment 8

[u278084]

Attachment: possible css change

This is a possible amendment to Wil's patch. I simply just dropped the marign-top css attribute so it comes down a little. Firebug css layout view is your friend :)

Unfortunately, it adds additional whitespace when you haven't logged in. But it's not that noticeable imo. I only have arabic and english on my box. Not sure what it looks like in other rtl languages.

Comment 9

[u278084]

Attachment: Oops

Almost immediately after submitting, I found a problem. Sorry for the bug spam.

Comment 10

[Justin Scott [:fligtar]]

I'm not a fan of cluttering up the header like this, fwiw.

Comment 11

[Rey Bango]

I don't see any issues with adding this to the header if it makes the lives of the contributors easier. From what I'm seeing, this would only be visible to a small subset of users.

Comment 12

[Nick Nguyen [:osunick]]

I agree with rey- if this is something that editors will use, we should add it- the standards for visual clarity shouldn't be as high since these are special users who know their way around

Comment 13

[Justin Scott [:fligtar]]

Being an editor doesn't mean I want my header to be fugly. In the global header redesign, we can have the design firm combine these into a single dropdown menu thing. I'll write a userscript to hide these from me in the meantime :)

Comment 14

[Wil Clouser [:clouserw]]

(In reply to comment #9)
> Created an attachment (id=363412) [details]
> Oops
> 
> Almost immediately after submitting, I found a problem. Sorry for the bug spam.

Normally I would block on pushing the rtl page down the extra 1.75em.  However, with the new design coming in I don't see it being a problem at this point.  If we didn't have the new design I'd file a bug to swap the "other applications" box over too.

Anyway, r22704.  Stephend:  please make sure this looks alright in all our browsers in rtl.  Thanks.

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED, using the following browsers:

* IE 6
* IE 7
* Safari 3.2.1
* Opera 9.6
* Firefox 2.0.0.20
* Firefox 3.x nightly build
* Firefox 3.0.6

Checked "fa", "ar", and "he" locales.