466261 - Missing Outbox icon in Folder Pane

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[CatThief]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081121 Minefield/3.1b2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081121 Shredder/3.0b1pre

The "specialFolder" icon for Outbox is missing inside the Folder Pane's folderTree. This icon is displayed properly in a tabmail-tab, but a generic folder icon is being used inside the Folder Pane instead.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Phil Ringnalda (:philor)]

Seems really unlikely to be a coincidence that that's the only special folder whose specialFolder- property has a space in it.

Comment 2

[Joe Sabash [:JoeS1]]

Just to narrow the regression window somewhat, it was still OK in:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081013 Lightning/1.0pre Shredder/3.0b1pre ID:20081013031030

Comment 3

[CatThief]

Per this thread -http://forums.mozillazine.org/viewtopic.php?f=29&t=956665 - another user reports that the image is OK with this build:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20080920112042 Lightning/1.0pre Shredder/3.0b1pre ID:20080920112042

Comment 4

[Joe Sabash [:JoeS1]]

OOPs
Actually meant to target this build for regression:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081113 Lightning/1.0pre Shredder/3.0b1pre ID:20081113031301

The icon is missing in that build.

Comment 5

[Joe Sabash [:JoeS1]]

And OK in build:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081112 Lightning/1.0pre Shredder/3.0b1pre ID:20081112031406

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Marking as blocking, since this is a regression.

Comment 7

[David :Bienvenu]

setting TFV as b2

Comment 8

[David :Bienvenu]

taking, though if someone knows how to fix this, please let me know :-)

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

jminta, would you be up for taking a run at this bug, either for beta2 or beta3?

Comment 10

[David :Bienvenu]

Attachment: proposed fix

this fixes it, so I suspect Phil is right. All I did was replace "Unsent Messages" with "Outbox" in the css and xml/xul. I'm not sure if this affects SM so I've asked Neil for sr on the folderWidgets.xml and folderUtils.jsm part (though I'm not sure the latter is used in SM). Or perhaps Neil has thoughts on a simpler fix.

Comment 11

[Joey Minta]

Comment on attachment 358760 [details] [diff] [review]
proposed fix

You also need to change http://mxr.mozilla.org/comm-central/source/mail/base/content/mail3PaneWindowCommands.js#1056 (and the SM copy too)

Comment 12

[David :Bienvenu]

Attachment: address jminta's comment

mmm, I wonder why that method doesn't simply check the folder flags...

Comment 13

[[e-mail]]

So, what's going on here was that the old RDF code was returning "Unsent Messages" as the special folder, which was fine as a generic attribute, but when applied to tree properties got split up into two tokens. Fortunately nobody noticed because the same problem applied to the CSS.

Now, jminta's JS-based folder tree doesn't know about this and creates a single atom for "SpecialFolder-Unsent Messages" which unsurprisingly doesn't match any CSS rules.

So, while the fix is to change the special folder to one not using a space, since this has a knock-on effect on the folder menus (which use the same special folder names), which are shared with the suite, via such windows as the account manager, this means that the special folder name has to be updated throughout the comm-central tree, not just the Thunderbird parts.

As an interim fix you could instead tweak suite's copies of folderMenus.css so that they accept either special folder name, but you still wouldn't want to update suite's msgMail3PaneWindow.js, since that's still using the RDF value.

Comment 14

[David :Bienvenu]

thx for the info, Neil.

I looked at the suite's copies of folderMenus.css and neither of them seem to reference Unsent. Am I looking in the wrong place(s)?

Comment 15

[David :Bienvenu]

Attachment: address Neil's comments

I found Unsent Messages references in suite's folderPane.css so I've added Outbox to them - is that what you intended, Neil? SM seemed to be working without that change, but I'm no expert :-)

Comment 16

[[e-mail]]

Comment on attachment 358988 [details] [diff] [review]
address Neil's comments

I suddenly realised that the only time the Unsent Messages folder appears in our UI is in the Go submenu, which is still RDF-based, and is therefore unaffected by the folderWidgets change.

Comment 17

[[e-mail]]

(In reply to comment #14)
> I looked at the suite's copies of folderMenus.css and neither of them seem to
> reference Unsent. Am I looking in the wrong place(s)?
No, you're quite right, and it's a bug, which I shall file in due course.

Comment 18

[Mark Banner (:standard8)]

Comment on attachment 358988 [details] [diff] [review]
address Neil's comments

This in general seems to be working, however you've missed both mailContentMenus.js instances:

http://mxr.mozilla.org/comm-central/source/mail/base/content/mailContextMenus.js#513

(Send unsent messages context menu item doesn't get displayed)

and you've also missed updating mail3PaneWindowCommands.js for SeaMonkey.

Comment 19

[David :Bienvenu]

(In reply to comment #18)

> 
> and you've also missed updating mail3PaneWindowCommands.js for SeaMonkey.
Ah, I didn't do that because in #13 Neil said not to do the suite's msgMail3PaneWindow.js, since that's still using the RDF value, and I thought he meant the suite's mail3PaneWindowCommands.js...

Comment 20

[Mark Banner (:standard8)]

(In reply to comment #19)
> (In reply to comment #18)
> 
> > 
> > and you've also missed updating mail3PaneWindowCommands.js for SeaMonkey.
> Ah, I didn't do that because in #13 Neil said not to do the suite's
> msgMail3PaneWindow.js, since that's still using the RDF value, and I thought he
> meant the suite's mail3PaneWindowCommands.js...

Ah, ok, I must admit I didn't actually test that.

Comment 21

[David :Bienvenu]

Attachment: address comments

I didn't change the SM context menu for the same reason...

I'm not seeing the outbox in my context menu, but that's also true in 2.0x, so there's something screwy with my profile...

Comment 22

[Mark Banner (:standard8)]

Comment on attachment 359302 [details] [diff] [review]
address comments

This works for both TB & SM. r=me.

Comment 23

[David :Bienvenu]

fix checked in.