466368 - garbled taskmenu icons in Modern theme on Mac

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Robert Kaiser]

When I checked in bug 318986, I caused taskmenu icons in Modern on Mac to be garbled because of bug 418774.

I have a simple patch to split up that image again, so we can work around bug 418774 for now.

Comment 1

[Robert Kaiser]

Attachment: split taskmenu icons again

Here's the quite simple patch to split taskmenu icons again. This seems to work fine here on Linux, I hope it does on Mac as well, Stefan, can you please check that?

Comment 2

[Stefan [:stefanh]]

Comment on attachment 350163 [details] [diff] [review]
split taskmenu icons again

Looks good.

Comment 3

[Stefan [:stefanh]]

Btw, have the browser icon always been that small? That is, I know the icon itself is 16x16, but the visual part doesn't line up with the other ones in the menu. On mac, the icons are left-aligned and it looks like there is much more empty space at the left of the browser icon that the rest.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 350163 [details] [diff] [review]
split taskmenu icons again

I think this should be safe to take for alpha, and it will improve the experience for our Mac Modern theme users.

Comment 5

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/500a37c0bb0b

Stefan, this has been that way at least since I did bug 318986. Maybe the icon should/could be moved 1px to the left, but I'd rather do such visual adjustments in a followup, as it's probably not Alpha material...