Closed
Bug 318986
Opened 19 years ago
Closed 17 years ago
Mozilla "M" logo still in Seamonkey component bar (Modern theme)
Categories
(SeaMonkey :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dluchini30, Assigned: kairo)
References
Details
Attachments
(3 files, 4 obsolete files)
8.62 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
4.82 KB,
image/png
|
neil
:
review+
|
Details |
2.06 KB,
image/png
|
neil
:
review+
|
Details |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.12) Gecko/20050915 Donzilla/0.8.1 (WML/1.3)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051203 SeaMonkey/1.5a
Although the new Seamonkey art is now out, the Mozilla "M" logo still resides in the lower-left toolbar and consequently in Window -> Navigator.
Reproducible: Always
Steps to Reproduce:
Always reproducable
Expected Results:
Logo should use new artwork or similar
Comment 1•19 years ago
|
||
this is with the Modern theme?
Assignee | ||
Comment 2•19 years ago
|
||
This is known and semi-intentional. Yes, it's with modern and we just haven't made up the new image yet. Same with window/component icons.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•19 years ago
|
Assignee: general → kairo
Comment 3•19 years ago
|
||
I'm not sure which icons you refer to ... I just installed SeaMonkey 1.0 on XP and while the images for the throbber, quick start, desktop, and Windows program menu are all sea monkeys, the system menu icon (which also appears in the Windows taskbar) is the old Navigator icon from the Netscape days.
Assignee | ||
Updated•18 years ago
|
Summary: Mozilla "M" logo still in Seamonkey toolbar → Mozilla "M" logo still in Seamonkey component bar (Modern theme)
Assignee | ||
Comment 4•17 years ago
|
||
Here's the jar/CSS part, moving us to using image regions for those icons and PNG images.
Attachment #293166 -
Flags: superreview?(neil)
Attachment #293166 -
Flags: review?(neil)
Assignee | ||
Comment 5•17 years ago
|
||
The globe has more or less grown to be the universal icon image for "browser", and even the composer component icon includes that symbolism, so I use a globe as the component icon for browser in those images.
The taskbar.png image includes all non-extension components, I just used the .gifs and made them alpha-transparent.
Attachment #293167 -
Flags: review?(neil)
Assignee | ||
Comment 6•17 years ago
|
||
taskmenu.png has the images used for the components in the "Window" menu, again browser gets the globe, the other images are taken from the .gifs.
Attachment #293168 -
Flags: review?(neil)
Assignee | ||
Comment 7•17 years ago
|
||
Comment on attachment 293166 [details] [diff] [review]
jar/CSS part: move to image-regions
>Index: mozilla/suite/themes/modern/jar.mn
>===================================================================
>- skin/modern/navigator/icons/btn1.gif (navigator/icons/btn1.gif)
>+ skin/modern/navigator/icons/btn1.png (navigator/icons/btn1.png)
Oops, ignore that change, that's related to another bug, as you might guess ;-)
Updated•17 years ago
|
Attachment #293166 -
Flags: superreview?(neil)
Attachment #293166 -
Flags: superreview+
Attachment #293166 -
Flags: review?(neil)
Attachment #293166 -
Flags: review+
Comment 8•17 years ago
|
||
Comment on attachment 293168 [details]
taskmenu.png with "M" replaced with a globe
The globe is the wrong size, it should be the same size as the one in the component bar.
Attachment #293168 -
Flags: review?(neil) → review-
Comment 9•17 years ago
|
||
Comment on attachment 293167 [details]
taskbar.png with "M" replaced with a globe
It looks fine here but the translucency fails against the menu/statusbar background. Please make it opaque.
Attachment #293167 -
Flags: review?(neil) → review-
Comment 10•17 years ago
|
||
Note: for a bonus, take the 14x13 icons, add transparent borders to expand them to 16x16 for the Window menu, but use -moz-image-region to extract the original 14x13 icons for the component bar.
Assignee | ||
Comment 11•17 years ago
|
||
(In reply to comment #10)
> Note: for a bonus, take the 14x13 icons, add transparent borders to expand them
> to 16x16 for the Window menu, but use -moz-image-region to extract the original
> 14x13 icons for the component bar.
The problem is that the mail and composer component bar icons are wider than 16px, and their window menu icons are not identical to those.
Assignee | ||
Comment 12•17 years ago
|
||
This taskbar.png has an opaque globe.
Attachment #293167 -
Attachment is obsolete: true
Assignee | ||
Updated•17 years ago
|
Attachment #293389 -
Flags: review?(neil)
Assignee | ||
Comment 13•17 years ago
|
||
This taskmenu.png uses the same globe as the new taskbar.png
Attachment #293168 -
Attachment is obsolete: true
Attachment #293390 -
Flags: review?(neil)
Assignee | ||
Comment 14•17 years ago
|
||
Attachment #293389 -
Attachment is obsolete: true
Attachment #293503 -
Flags: review?(neil)
Attachment #293389 -
Flags: review?(neil)
Assignee | ||
Comment 15•17 years ago
|
||
Neil mentioned on IRC that the new globes don't match the globe in the composer icon, so I redid the globes, matching composer better.
Attachment #293390 -
Attachment is obsolete: true
Attachment #293504 -
Flags: review?(neil)
Attachment #293390 -
Flags: review?(neil)
Updated•17 years ago
|
Attachment #293503 -
Flags: review?(neil) → review+
Updated•17 years ago
|
Attachment #293504 -
Flags: review?(neil) → review+
Assignee | ||
Comment 16•17 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•