466384 - "ASSERTION: OnDataAvailable implementation consumed no data" loading standalone video from local file

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When I load a standalone ogg video file, I get the assertion:

###!!! ASSERTION: OnDataAvailable implementation consumed no data: 'Error', file /home/dbaron/builds/mozilla-central/mozilla/netwerk/base/src/nsInputStreamPump.cpp, line 529

This appears to be happening because the OnDataAvailable works its way through a chain of various listeners and finds its way to nsMediaDocumentStreamListener::OnDataAvailable, where mNextStream is null, so the function returns without doing anything.

Steps to reproduce:
  1. save http://piercedotzler.com/asa/obama-scaled-high.ogg to a local file
  2. load that local file in Firefox

Actual results: assertion (above)
Expected results: no assertion

Comment 1

[Matthew Gregan [:kinetik]]

nsFileStreamStrategy doesn't need or use the existing channel, it (re)opens the channel as a local file.  I think nsMediaDocumentStreamListener::OnStartRequest should return NS_BINDING_ABORTED if no mNextStream listener is attached.  Alternately, the nsFileStreamStrategy could attach a listener that just returns the same from OnStartRequest, but that seems uglier.

Comment 2

[timeless]

Attachment: this fixes it [Checkin: Comment 5]

Comment 3

[timeless]

fwiw, this has nothing to do with video/audio, it existed for plugin content and has since at least 2003 (initial version). I suspect there's a much older bug. but my "current" archive doesn't reach that far back.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 355089 [details] [diff] [review]
this fixes it
[Checkin: Comment 5]

Looks good.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 355089 [details] [diff] [review]
this fixes it
[Checkin: Comment 5]

http://hg.mozilla.org/mozilla-central/rev/9f497b1505d2

Comment 6

[u88484]

Could this have caused bug 472239?

Comment 7

[philippe (part-time)]

Is bug 472230 a regression from this ?

Comment 8

[u88484]

Can this be backed out to fix bug 472239 and bug 472239?  It has been confirmed that backing out this patch locally, fixes those bugs.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Gah.  Plugin documents do weird stuff with the OnStartRequest.

I'll fix in one of the two regression bugs.  Please don't reopen bugs for regressions, ok?