Closed Bug 466439 Opened 11 years ago Closed 10 years ago

calIRelation/calIAttachment need proper cloning facility

Categories

(Calendar :: Internal Components, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dbo, Assigned: martinschroeder)

Details

Attachments

(1 file, 1 obsolete file)

Those objects store a reference to their base item. In case of cloning a calendar item, currently only the set of relations/attachments is cloned, leaving a reference to the item that has been cloned.
Flags: wanted-calendar1.0+
Flags: blocking-calendar1.0?
Daniel, are willing to fix this one? If so, then please mark blocking+, otherwise blocking- and wanted+.
Summary: calIRelation/calIAttachment need propery cloning facility → calIRelation/calIAttachment need property cloning facility
Summary: calIRelation/calIAttachment need property cloning facility → calIRelation/calIAttachment need proper cloning facility
Assignee: nobody → mschroeder
Status: NEW → ASSIGNED
Attached patch Patch v1 (obsolete) — Splinter Review
This is a first try (also my first time dealing with the backend)... Daniel, it would be great to get some input from you if this patch heads in the right direction.
Attachment #382115 - Flags: review?(dbo.moz)
Attachment #382115 - Flags: review?(dbo.moz) → review-
Comment on attachment 382115 [details] [diff] [review]
Patch v1

calIAttachment::item, calIRelation::item still seem to be wrong (refer to the old item). However, ad hoc I don't remember why we need to refer to the item at all? Philipp, you do?
If possible we should get rid of the item attribute to avoid circular references. Since calIRelation is not used yet, we might get away with removing it until we find out we need it.

I don't see why calIAttachment would need an item.
I don't think this should block 1.0. Attachments and Relations are not really highly used features and they are not broken per se.
Flags: blocking-calendar1.0? → blocking-calendar1.0-
Sounds like something that would benefit from a xpcshell testcase.
Flags: in-testsuite?
This patch still has the cloning facility but the references to an item have been removed.
Attachment #382115 - Attachment is obsolete: true
Attachment #384294 - Flags: review?(dbo.moz)
Attachment #384294 - Flags: review?(dbo.moz) → review+
Comment on attachment 384294 [details] [diff] [review]
[checked in] Patch v1

looks good; r=dbo
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/bab2dcc9b4de>

I'll adapt the existing unit tests, and add additional ones next week.
Target Milestone: --- → 1.0
Attachment #384294 - Attachment description: Patch v1 → [checked in] Patch v1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.