Use proper strings in Preference Pane

VERIFIED FIXED in fennec1.0b2

Status

Firefox for Android Graveyard
General
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: mfinkle, Assigned: Gavin)

Tracking

(Blocks: 1 bug)

Trunk
fennec1.0b2

Details

Attachments

(3 attachments)

We have some placeholder strings in the preference UI. Let's get the right strings in place. We would like some l10n review on our strings, so the right strings would be helpful.
(Reporter)

Updated

10 years ago
Keywords: uiwanted

Updated

10 years ago
Flags: blocking-fennec1.0+
Blocks: 474496
Blocks: 477628

Updated

10 years ago
tracking-fennec: --- → 1.0b2+
Flags: blocking-fennec1.0+
(Reporter)

Updated

10 years ago
Whiteboard: [good first bug]

Comment 1

10 years ago
Lots of other localizers might have interest in this.  Mark, do you want me to surface this on my blog?  You'll probably get 10 to 15 people CC-ed on this?  Or, should we just leave it to Stas and Gandalf?  Let me know and I will communicate this.
(Reporter)

Comment 2

10 years ago
Seth - I want Madhava to tell us what the en-US strings should be first. Other people could offer up suggestions and Madhava could just review them.
Well, right off the bat, we can just strike the current descriptions.  They're just filler text, so there's no point translating them.  More on the replacements to come...
Created attachment 365699 [details]
my suggestions for new text

Here are my suggestions.  Not all prefs have descriptions where/if the title was clear enough.  Where there are descriptions, I'm trying to provide some relevant non-expert-appropriate information to help with the decision.
Actually, a couple of additional changes

- "Show images" rather than "Show site images"
- "Allow cookies" rather than "Accept cookies from sites"
- remove the ellipsis (...) from the [Clear...] button (re: private data button, unless it really brings up a dialog.  In which case, actually -- do we really need a dialog?  Can't we just have it delete everything relevant?
Keywords: uiwanted

Updated

9 years ago
Assignee: nobody → gavin.sharp
Created attachment 376702 [details]
screenshot

Implements the new suggestions per comment 4/comment 5 with one slight change:

> - "Show images" rather than "Show site images"

"Remember passwords for sites" seemed to match this pattern as well, so I changed it to just be "Remember passwords".

I also didn't touch the "JavaScript Tracing" string since I assume we're going to be removing it?

I find the "Enable" and "On/Off" contrast between the titles and widgets a bit odd, but not sure what the best way to address that would be.
Attachment #376702 - Flags: ui-review?(madhava)
(In reply to comment #6)
> I find the "Enable" and "On/Off" contrast between the titles and widgets a bit
> odd, but not sure what the best way to address that would be.

Actually I guess that applies to all of the descriptions, really. None of Show/Allow/Enable/Remember match up semantically with "On/Off", really. Don't mean to wander off track here, though; that's a minor issue, and the new strings are certainly a step in the right direction.
Status: NEW → ASSIGNED
OS: Windows XP → All
Hardware: x86 → All
Whiteboard: [good first bug]
Comment on attachment 376702 [details]
screenshot

The revised text is great.  I think that the buttons should probably be yes/no rather than on/off.
Attachment #376702 - Flags: ui-review?(madhava) → ui-review+
Created attachment 378638 [details] [diff] [review]
patch
Attachment #378638 - Flags: review?(mark.finkle)
(Reporter)

Updated

9 years ago
Attachment #378638 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mobile-browser/rev/e9718c3681ae
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → B2
No longer blocks: 474496
verified FIXED On builds:


Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090818 Fennec/1.0a3pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821
Fennec/1.0b3pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre)
Gecko/20090808 Fennec/1.0b3pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.