Closed Bug 474496 Opened 12 years ago Closed 12 years ago
add section buttons to the prefs pane
Wireframes are here: https://wiki.mozilla.org/Mobile/UI/Designs/TouchScreen/workingUI#Preferences Same model as for the add-ons manager and downloads manager -- a vertically pannable list with rows that expand when you tap on them. "Table of Contents" buttons at the top scroll you, quickly, down to the relevant section. Buttons are all finger-sized (i.e. no checkboxes) -- see second wireframe for some examples (including off to the right of the screen wireframe).
Can I get a mockup that uses our current preferences? We currently only have two sections that should always fit on screen, and don't have any multiple choice preferences, so I'm not sure that design gains us anything over the current prefpane. Are we planning on adding more preferences before we do this?
I think the only part missing is the "table of contents" buttons Could we auto-gen those buttons by scanning the list for "sections"?
I'm going to morph this bug to cover just adding the buttons - we can revisit a newer UI when we have more prefs.
Summary: Update the preferences UI → add section buttons to the prefs pane
Might need to tweak the styling a bit, but this works.
Attachment #382135 - Flags: review?(mark.finkle)
Comment on attachment 382135 [details] [diff] [review] patch >+ <hbox pack="center" id="buttons" oncommand="BrowserUI.showPrefSection(event.target.getAttribute('section'));"> >+ <toolbarbutton id="prefs-content-button" class="show-text button-dark" label="&content.title;" section="prefs-content"/> >+ <toolbarbutton id="prefs-privacy-button" class="show-text button-dark" label="&privacy.title;" section="prefs-privacy"/> silly nit: we use "linkedxxx" in other places (continuing the "linkedpanel", "linkedbrowser" naming from toolkit and tabbrowser). How do you feel about "linkedsection" ?
Attachment #382135 - Flags: review?(mark.finkle) → review+
pushed with that change: https://hg.mozilla.org/mobile-browser/rev/1849aa536f67
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → B2
verified FIXED with builds: Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090818 Fennec/1.0a3pre and Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821 Fennec/1.0b3pre and Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre) Gecko/20090808 Fennec/1.0b3pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.