466929 - [silme] add has_entity() to diff/l10nobject.py and diff/entitylist.py

Status: RESOLVED FIXED

(Mozilla Localizations :: Infrastructure, defect)

Description

[Adrian Kalla [:adriank]]

Attachment: add hasEntity() to EntityListDiff

From an IRC discussion with Gandalf: would be nice to have that methods.

L10nObjectDiff.hasEnity() is implemented in the same way like L10nObjectDiff.getEnity(), which is really slowing down Silme, if used. 
But if someone will need to have that...

Comment 1

[Adrian Kalla [:adriank]]

Attachment: add hasEntity() to L10nObjectDiff

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 350256 [details] [diff] [review]
add hasEntity() to L10nObjectDiff

nope, it's part of the lib, we have to have a full featured code for iterating through elements and seeking for entity.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 350255 [details] [diff] [review]
add hasEntity() to EntityListDiff

One liner is better here

def hasEntity(self, id): return self.has_key(id)

Comment 4

[Adrian Kalla [:adriank]]

Attachment: (v2) add hasEntity() to EntityListDiff

changed according to review in comment #3

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

I'd like to take this for 0.5.1

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 350924 [details] [diff] [review]
(v2) add hasEntity() to EntityListDiff

the patch needs an update, but r+ of course :)

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

At least EntityListDiff.has_entity, not sure about L10nObjectDiff

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

http://hg.mozilla.org/users/zbraniecki_mozilla.com/silme/rev/48e6eaa65a63
http://hg.mozilla.org/users/zbraniecki_mozilla.com/silme/rev/4c3bb0affa8d

done for entitylistdiff. Leaving the bug open for L10nObjectDiff

Comment 9

[Adrian Kalla [:adriank]]

Gandalf: L10nObjectDiff.has_entity() will need (nearly) the same code like for get_entity():
"L10nObjectDiff.get_entity() should be less time consuming (better not to do get_entitylistdiff which does get_entities to get one single entity...)" for Silme 0.7 ( https://wiki.mozilla.org/Silme:0.7 )

Nominating for 0.7.

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

Fixed: http://hg.mozilla.org/users/zbraniecki_mozilla.com/silme/rev/fe0675299497

The performance is a material for a separate bug. I improved it by 30%, and I expect we can get another 30% but it'll still be pretty slow (bare in mind we have to find both, added and removed to mark it as "modified" in get_entity. In has_entity we can skip it)