Closed Bug 467051 Opened 11 years ago Closed 10 years ago

Introduce GLOBAL_DEPS to build system (gfx/cairo)

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: Callek, Assigned: Callek)

References

Details

Attachments

(1 file)

From Bug 463824 c#0

vlad, roc. I'm not sure the rules in gfx/cairo... would you prefer us to take any of this there, or would I need to port it upstream somehow or what?

confirm if "yes" do it, wontfix if "no" please.

I won't bother with a patch until I get an answer one way or the other, as I'm unfamiliar here.
I can say if the fix is wanted, but I can point out that the Makefile.in under cairo are Mozilla only and have little to do with the upstream versions. So I think you should handle them just like all the other Makefile.ins in the tree...
Yeah, the makefiles in cairo are not from upstream.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Product: Core → Core Graveyard
This should not have ended up in core graveyard.
Component: GFX → GFX: Thebes
Product: Core Graveyard → Core
QA Contact: general → thebes
Attached patch v1Splinter Review
Just Do It.

Note, this does add a few more dependancies where I changed this, but arguably good ones.

I chose not to modify: mozilla/gfx/cairo/cairo/test/Makefile.in which appears to be AutoMake generated and imported from upstream.
Assignee: nobody → bugspam.Callek
Status: NEW → ASSIGNED
Attachment #448325 - Flags: review?(vladimir)
Attachment #448325 - Flags: feedback?(ted.mielczarek)
Attachment #448325 - Flags: feedback?(ted.mielczarek) → feedback+
http://hg.mozilla.org/mozilla-central/rev/34464e02b575
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.