Closed Bug 467093 Opened 16 years ago Closed 16 years ago

3.0 beta 1 - update shipped-locales with locales to include in the build

Categories

(Thunderbird :: Build Config, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b1

People

(Reporter: Bienvenu, Assigned: gozer)

References

Details

Attachments

(1 file)

Simon will get gozer the list of locales to include in 3.0 beta 1 by Monday, Dec. 1...Not sure if build config is the right component, but ...
Flags: blocking-thunderbird3+
Blocks: 467363
af 6d7266ae7795 ar 8fe9d82e2a9f be 1024dffd45da cs d834a4624bee de 0346fbb75255 en-GB 4601bfa19e4f es-AR a4c5827fb901 es-ES 9487a03ec402 et 18500f0b88ba eu 315f4208b728 fr dc07428312a5 fy-NL 79d4f2920eb2 ga-IE e4f65756a9ac he beab2fe87a0e hu 5a22808c7ce7 id 8de0c317f4db it 76aa831d71fb ja 4f2befcece68 ja-JP-mac 0224b742f6e0 ka d3e617caa390 ko 62a62aed940f lt e621b85d388c nb-NO bb6c8e2cd8d6 nl d01239d67953 nn-NO dc1345e72f40 pa-IN 9d66bc50e688 pl ace15e793a3c pt-BR 1cff9ebf0eee pt-PT 095428a10aa7 ro b6eeb1ae277c ru f833d5681a01 si e348a155439e sk e76e0a2d155d sq 551f3e42e5a6 sv-SE ff7390c6a162 uk 96f45bc33403 zh-CN bd5064a9f9e3 zh-TW 84f1c168d64e
Is it safe to update shipped-locale to this 2 column format? If so, it probably have been updated *before* the builds were tagged. For now, I'll just directly tag l10n-central repositories from these revisions.
Gozer, sorry for the confusion. No, you shouldn't change shipped-locales to this format. This was just my way of telling you the locale revisions.
Thought its probably worth making sure we've got the same list in shipped-locales for future reference.
Is there any harm in including the revision numbers in there too ? That would make it much straightforward when releasing, as the opt-in revisions would be tagged as part of the comm-central sources, nice and neat.
this matches the builds on the ftp site, and sipaq's list.
Attachment #351007 - Flags: review?
Can we also add the opted-in revisions to that file to simplify builds ? Especially if that file isn't used for anything else, it would make a lot of sense to me. And, yes, where did the 'ca' locale go ?
Attachment #351007 - Flags: review? → review?(bugzilla)
I can land this on the trunk if Simon thinks it looks OK. I don't know about changing the format of the file, and I'm also curious about where the ca locale went.
Comment on attachment 351007 [details] [diff] [review] update the new list of b1 locales r=sipaq I'm fine with putting the locale revisions next to the different locales as long as we (especially gozer) is reasonably sure, that this won't break some kind of build automation that we have going on. As for the Catalan (ca) locale. They did not manage to get their locale green for beta1 and therefore did not opt-in.
Attachment #351007 - Flags: review?(bugzilla) → review+
Status: NEW → ASSIGNED
We have a new locale revision for nn-NO (Norwegian Nynorsk), due to them fixing bug 467511 on their side. It's da5123f9eb10 I'll let you know once the si team (Sinhala) fixes this as well.
The si (Sinhala) team has fixed their issue as well (bug 467511). The new revision is 7faca4f64ff2
(In reply to comment #9) > (From update of attachment 351007 [details] [diff] [review]) > r=sipaq > > I'm fine with putting the locale revisions next to the different locales as > long as we (especially gozer) is reasonably sure, that this won't break some > kind of build automation that we have going on. I know for a fact none of our current build automation relies on the content of this file, as for what else might be looking at this file, I don't know for sure.
Updated build configuration for these 2 locales: comparing with ssh://hg.mozilla.org/users/gozer_mozillamessaging.com/misc changeset: 37:05c94df2a231 tag: tip user: Philippe M. Chiasson <gozer@mozillamessaging.com> date: Wed Dec 03 14:27:17 2008 -0500 summary: Bug 467093. Update build shipped-locales for the now fixed si and nn-NO locales.
Blocks: 467813
this patch landed on trunk, marking fixed. gozer, there's also gu-IN - http://hg.mozilla.org/l10n-central/gu-IN/rev/8c9240907773
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
So that's a new locale to build in the upcoming respin. Pushed to the release scripts. hg push comparing with ssh://hg.mozilla.org/users/gozer_mozillamessaging.com/misc changeset: 39:a048d07e307f tag: tip user: Philippe M. Chiasson <gozer@mozillamessaging.com> date: Thu Dec 04 12:15:58 2008 -0500 summary: Bug 467093. Add gu-IN to shipped-locales for the upcoming rc2 builds.
Simon, is gu-IN in or out? It's not in the list you gave above, so I assume it's out. But, in bug 467511 they're fixing the beta 1 problem, which implies that maybe they're in? Gozer is doing respins for rc2 today, so we're just double checking.
gu-IN is out. They haven't finished their localization for TB3 yet. Gozer, please remove them from shipped-locales. In the future, please either correspond with me when you add a locale to the pack that I did not name or at least take a look at the l10n dashboard. The latter would have told you, that gu-IN is still missing 772 strings for completion and is therefore no candidate for beta1 inclusion. Thanks.
no one put gu-IN in shipped-locales, afaik - we were just double checking that it was in fact out.
Ah sorry, then I misunderstood gozer's last message here in the bug. Sorry again!
yes, I can see how that would be misleading, and my comment wasn't helpful - I just meant that they had landed a fix for that same bug, not realizing it wasn't part of the shipped-locales. And it's definitely not built, nor is it in the trunk version of shipped-locales...
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: