467351 - get rid of bug fix for [Bug 348009] Drag and Drop in Month view freezes Un*x desktops

Status: VERIFIED FIXED

(Calendar :: Calendar Views, defect)

Description

[Berend Cornelius]

As I have tested the above mentioned bug, that lead to the freezing of a Unix session during drag'n drop in the calendar-month-view is apparently not needed anymore and can therefor be removed.

Comment 1

[Berend Cornelius]

Attachment: patch v. #1

Before I am asking for review I want to get some feedback if somebody runs into a freezing desktop with this patch applied

Comment 2

[Andreas Treumann]

I checked the first patch and found a new minor issue.

STR:
===

- switch to weekview
- drag an all day event to the all day section of the next day
- wait a moment that the drag shadow gets visible
- move and drop the event outside the all day section
- drag shadow is furthermore visible

Comment 3

[Berend Cornelius]

Comment on attachment 350762 [details] [diff] [review]
patch v. #1

Stefan, could you review this? I applied the changes  due to Philipp's recommendation in  Bug 416138 -  Moving of all-day-events in weekview not possible, but shows possibility, comment #14.
If you feel unsure about it you could pass the review to Philipp. Andreas tested this patch and found it was Ok.
His comment #2 is not relevant for this issue.

Comment 4

[Stefan Sitter [:ssitter]]

Comment on attachment 350762 [details] [diff] [review]
patch v. #1

I don't have Unix access and currently can't build on Windows either. Please take over.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 350762 [details] [diff] [review]
patch v. #1

Some simple testing didn't cause any session hangs.

r=philipp

Comment 6

[Berend Cornelius]

pushed patch v. #1 to comm-central:

http://hg.mozilla.org/comm-central/rev/1c1490c69a67

->fixed

Comment 7

[Martin Schröder [:martinschroeder]]

Berend, what about the issue from comment#2?

Comment 8

[Martin Schröder [:martinschroeder]]

(In reply to comment #7)
> Berend, what about the issue from comment#2?

Sorry, haven't read comment#3. ;)

Comment 9

[Andreas Treumann]

Checked in lightning and sunbird build 20081207 -> VERIFIED.