Closed
Bug 467351
Opened 12 years ago
Closed 12 years ago
get rid of bug fix for [Bug 348009] Drag and Drop in Month view freezes Un*x desktops
Categories
(Calendar :: Calendar Frontend, defect)
Calendar
Calendar Frontend
Tracking
(Not tracked)
VERIFIED
FIXED
1.0b1
People
(Reporter: berend.cornelius09, Assigned: berend.cornelius09)
Details
Attachments
(1 file)
2.63 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
As I have tested the above mentioned bug, that lead to the freezing of a Unix session during drag'n drop in the calendar-month-view is apparently not needed anymore and can therefor be removed.
Assignee | ||
Updated•12 years ago
|
Version: unspecified → Trunk
Assignee | ||
Comment 1•12 years ago
|
||
Before I am asking for review I want to get some feedback if somebody runs into a freezing desktop with this patch applied
Assignee: nobody → Berend.Cornelius
Status: NEW → ASSIGNED
Comment 2•12 years ago
|
||
I checked the first patch and found a new minor issue. STR: === - switch to weekview - drag an all day event to the all day section of the next day - wait a moment that the drag shadow gets visible - move and drop the event outside the all day section - drag shadow is furthermore visible
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 350762 [details] [diff] [review] patch v. #1 Stefan, could you review this? I applied the changes due to Philipp's recommendation in Bug 416138 - Moving of all-day-events in weekview not possible, but shows possibility, comment #14. If you feel unsure about it you could pass the review to Philipp. Andreas tested this patch and found it was Ok. His comment #2 is not relevant for this issue.
Attachment #350762 -
Flags: review?(ssitter)
Updated•12 years ago
|
Attachment #350762 -
Flags: review?(ssitter) → review?(philipp)
Comment 4•12 years ago
|
||
Comment on attachment 350762 [details] [diff] [review] patch v. #1 I don't have Unix access and currently can't build on Windows either. Please take over.
Comment 5•12 years ago
|
||
Comment on attachment 350762 [details] [diff] [review] patch v. #1 Some simple testing didn't cause any session hangs. r=philipp
Attachment #350762 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 6•12 years ago
|
||
pushed patch v. #1 to comm-central: http://hg.mozilla.org/comm-central/rev/1c1490c69a67 ->fixed
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
Target Milestone: --- → 1.0
Comment 8•12 years ago
|
||
(In reply to comment #7) > Berend, what about the issue from comment#2? Sorry, haven't read comment#3. ;)
Comment 9•12 years ago
|
||
Checked in lightning and sunbird build 20081207 -> VERIFIED.
Status: RESOLVED → VERIFIED
Updated•11 years ago
|
Target Milestone: 1.0 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•