remove support for "main" as a plugin initialization function

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

({dev-doc-complete})

Trunk
x86
Mac OS X
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

5.10 KB, patch
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
We should remove support for calling "main" as a plugin initialization function. Plugins should always use NP_GetEntryPoints on Mac OS X. Plugin vendors were informed of this change in August of 2008. Barring any major complications, this change should take effect in Gecko 1.9.2 (or whatever comes after 1.9.1).
(Assignee)

Comment 1

10 years ago
Created attachment 350850 [details] [diff] [review]
fix v1.0

This works with all major plugins on Intel Mac OS X.
Attachment #350850 - Flags: review?(smichaud)
Comment on attachment 350850 [details] [diff] [review]
fix v1.0

This looks fine to me.

I tested it (together with the v1.0 patch for bug 467417, attachment
350836 [review]) on my old G4 PPC Mac running OS X 10.4.11, and had no
problems.  For more info see bug 467417 comment #2.
Attachment #350850 - Flags: review?(smichaud) → review+
(Assignee)

Updated

10 years ago
Attachment #350850 - Flags: superreview?(jst)
(Assignee)

Updated

10 years ago
Attachment #350850 - Flags: superreview?(jst) → superreview?(roc)
Attachment #350850 - Flags: superreview?(roc) → superreview+
(Assignee)

Comment 3

10 years ago
Created attachment 352041 [details] [diff] [review]
fix v1.1

same as v1.0 but updated to tip
Attachment #350850 - Attachment is obsolete: true
(Assignee)

Comment 4

10 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/deac64488b1a
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Keywords: dev-doc-needed
See https://developer.mozilla.org/en/Updating_plug-ins_for_Firefox_3.6
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.