Closed Bug 467429 Opened 11 years ago Closed 11 years ago

remove support for "main" as a plugin initialization function

Categories

(Core :: Plug-ins, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

We should remove support for calling "main" as a plugin initialization function. Plugins should always use NP_GetEntryPoints on Mac OS X. Plugin vendors were informed of this change in August of 2008. Barring any major complications, this change should take effect in Gecko 1.9.2 (or whatever comes after 1.9.1).
Attached patch fix v1.0 (obsolete) — Splinter Review
This works with all major plugins on Intel Mac OS X.
Attachment #350850 - Flags: review?(smichaud)
Comment on attachment 350850 [details] [diff] [review]
fix v1.0

This looks fine to me.

I tested it (together with the v1.0 patch for bug 467417, attachment
350836 [review]) on my old G4 PPC Mac running OS X 10.4.11, and had no
problems.  For more info see bug 467417 comment #2.
Attachment #350850 - Flags: review?(smichaud) → review+
Attachment #350850 - Flags: superreview?(jst)
Attachment #350850 - Flags: superreview?(jst) → superreview?(roc)
Attachment #350850 - Flags: superreview?(roc) → superreview+
Attached patch fix v1.1Splinter Review
same as v1.0 but updated to tip
Attachment #350850 - Attachment is obsolete: true
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/deac64488b1a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.