467472 - Inconsistent painting with <svg:marker>, dynamic overflow:visible

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase (dynamic)

The testcase has a seemingly random amount of blue in it.  This seems to be a painting issue, since it can change when I switch windows and can even depend on which tab I switched from.

Comment 1

[Jesse Ruderman]

Attachment: reference (static)

Comment 2

[Jesse Ruderman]

Based on layout/reftests/svg/dynamic-marker-01.svg

Comment 3

[Robert Longson [:longsonr]]

I think the check in for bug 462369 fixed this.

Comment 4

[Jesse Ruderman]

Yes, looks like this is fixed.

Comment 5

[Jesse Ruderman]

I'm seeing this bug again.

Comment 6

[Robert Longson [:longsonr]]

I think bug 472135 fixed this.

Comment 7

[Robert Longson [:longsonr]]

Just checked in the debugger and it does use the new refresh code path.

Comment 8

[Jonathan Griffin (:jgriffin)]

Attachment: invalidate reftest

Comment 9

[Robert Longson [:longsonr]]

Please don't add files to the bugs directory we're trying to get rid of it. Instead add them to the parent directory with a file name that indicates what you are testing. In this case perhaps dynamic-marker-02.svg would be appropriate.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Did you test that the reftest failed in a build that had the bug, and passes in one without it?

Comment 11

[Jonathan Griffin (:jgriffin)]

Attachment: invalidate reftest

Moved out of the bugs folder and named as dynamic-marker-02, as suggested.

The test SVG reproduces the problem on this build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2008/12/2008-12-01-02-mozilla-central/

To repro it on that build you have to manually add a line of code:

setTimeout(boom, 2000);

as I don't believe that build supports the "MozReftestInvalidate" event, and so the test cannot be run as-is in reftest.

Test passes as-is on current trunk builds.

Comment 12

[Robert Longson [:longsonr]]

Comment on attachment 387668 [details] [diff] [review]
invalidate reftest

You should do what the other reftests do i.e. something along the lines of

document.addEventListener("MozReftestInvalidate", boom, false);
// in case we're not gecko
setTimeout(boom, 5000);

That way it will work on abuild/browser that does not support MozReftestInvalidate will still be OK.

Comment 13

[Jonathan Griffin (:jgriffin)]

Attachment: invalidate reftest

Thanks for the suggestion; I have added the setTimeout() to the test so that it works on browsers that don't support MozReftestInvalidate.

Comment 14

[Jonathan Griffin (:jgriffin)]

Pushed test from comment 13 as http://hg.mozilla.org/mozilla-central/rev/6beb76d1c2d8