451332 - Need tests for invalidation issues

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I coulda sworn we had a bug on this already....

Comment 1

[Jesse Ruderman]

Would it make sense to do this as a reftest mode where it makes sure everything gets drawn?  Or do you also want to be able to test for things like "too much repainting" and "unnecessary flickering"?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Reftest already makes sure everything is redrawn.  That's the problem.  It can't detect missing invalidates.

Comment 3

[Jesse Ruderman]

By "makes sure everything gets drawn" I mean "checks that everything gets drawn".

Comment 4

[Boris Zbarsky [:bzbarsky]]

For now it would be good to just be able to test cases when something should be repainted and isn't.

Comment 5

[cmtalbert]

Would it be possible/worthwhile for us to use Roc's "invalidation events" in
bug 450930 for this?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Possible but not very convenient for writing tests with.

Comment 7

[(not currently active) Ted Mielczarek]

-> reftest for now, maybe it ought to go into "new framworks" though, if reftest can't be made to do this.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Clint, would you or someone else (perhaps a volunteer) be able to go through the list of bugs that this bug blocks, and create invalidation reftests for them using the work in bug 471365? Also see
http://weblogs.mozillazine.org/roc/archives/2009/01/invalidation_re.html

Comment 9

[cmtalbert]

(In reply to comment #8)
> Clint, would you or someone else (perhaps a volunteer) be able to go through
> the list of bugs that this bug blocks, and create invalidation reftests for
> them using the work in bug 471365? Also see
> http://weblogs.mozillazine.org/roc/archives/2009/01/invalidation_re.html
Yes, I'd love to.

Comment 10

[cmtalbert]

(In reply to comment #9)
> (In reply to comment #8)
> > Clint, would you or someone else (perhaps a volunteer) be able to go through
> > the list of bugs that this bug blocks, and create invalidation reftests for
> > them using the work in bug 471365? Also see
> > http://weblogs.mozillazine.org/roc/archives/2009/01/invalidation_re.html
> Yes, I'd love to.
I hit commit a little too soon.  I'd love to, and I'll do some myself, as well as probably recruiting other volunteers to help out.  So if anyone is interested in volunteering, let me know, or just jump right in.

Comment 11

[(not currently active) Ted Mielczarek]

Did the work in bug 471365 fix this?

Comment 12

[Boris Zbarsky [:bzbarsky]]

I believe so, yes.  We could move this to a tracking bug for writing those tests, I guess.

Comment 13

[Jonathan Griffin (:jgriffin)]

All bugs in this list now have reftests, so I'm marking this as resolved.