467483 - Implement "Solved threads only (for forums):" functionality

Status: VERIFIED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

URL: http://support-stage.mozilla.org/tiki-newsearch.php?locale=en&q=quality+feedback+agent&where=f&sa=&filter_lang=1&l=en&en_too=1&lastmodif=0&type=0&answered=1&author=

The "New SUMO Search Engine -- High Level Summary" PDF mentions it, but I thought I'd file it so we don't lose track of it: the "Answered threads only (for forums) :" checkbox/flag doesn't seem to do anything.

Comment 1

[Paul Craciunoiu [:paulc]]

How is this related to bug 436878? Is there info on newsearch vs (old, current) search?
New sounds like the future, so I wanna make sure I'm not fixing bug 436878 right before we replace the search :)

Comment 2

[Paul Craciunoiu [:paulc]]

Attachment: Patch for indexer-forums and tiki-newsearch

Adds a new field <status> to the indexed files and makes use of it in tiki-newsearch.php

Comment 3

[Paul Craciunoiu [:paulc]]

Attachment: Small diff for sphinx.conf

As a result of the previous patch, "status" needs to be added to the sphinx configuration which doesn't seem to be under svn. I did a diff, it's one line of code that goes into:
---
source forums
{
...
---

Comment 4

[Paul Craciunoiu [:paulc]]

(In reply to comment #0)
> URL:
> http://support-stage.mozilla.org/tiki-newsearch.php?locale=en&q=quality+feedback+agent&where=f&sa=&filter_lang=1&l=en&en_too=1&lastmodif=0&type=0&answered=1&author=
> 
> The "New SUMO Search Engine -- High Level Summary" PDF mentions it, but I
> thought I'd file it so we don't lose track of it: the "Answered threads only
> (for forums) :" checkbox/flag doesn't seem to do anything.

Actually, answered threads are different than solved threads, at least the way newsearch has them currently. Answered means that replies were posted, I believe. Much confusing, I know. We could add a checkbox for solved threads, or replace the "answered" one, but as per bug 493150, we'll be removing the UI anyway.


I should also mention that the first patch defaults searching for solved threads only. To search for all threads you need to add solved_only=0 in the URL. No UI for this yet, needs some input from David :)

Comment 5

[E. Cooper [:ecooper]]

Comment on attachment 378825 [details] [diff] [review]
Patch for indexer-forums and tiki-newsearch

This acts as outlined in the second half of comment 4. 

To see it in action, the forums need to be reindexed and then the indices need rotated. That's cron'd on stage and prod, though.

Comment 6

[E. Cooper [:ecooper]]

Comment on attachment 378826 [details] [diff] [review]
Small diff for sphinx.conf

IT will need to add this line to sphinx.conf on both stage and prod.

I assume searchd needs to be restarted to begin using the new conf.

Comment 7

[Paul Craciunoiu [:paulc]]

Committed attachment 378825 [details] [diff] [review] in r26070 / r26071.

Assigning to IT. We need two things here:
1) Update sphinx.conf as per comment 3
2) Restart searchd on staging to use the new conf, and also on prod when we push. It'd be good to test it on staging before we push.

Thanks!

Comment 8

[Reed Loden [:reed]]

(In reply to comment #7)
> Assigning to IT. We need two things here:
> 1) Update sphinx.conf as per comment 3
> 2) Restart searchd on staging to use the new conf, and also on prod when we
> push. It'd be good to test it on staging before we push.

Mind filing a separate IT bug just for this, please? Thanks!

Comment 9

[Paul Craciunoiu [:paulc]]

Marking this fixed, filed bug 494327 for IT.

Comment 11

[Laura Thomson :laura]

Comment on attachment 378826 [details] [diff] [review]
Small diff for sphinx.conf

Do we need sphinxd restarted on stage/prod for this to take effect?

Comment 12

[Paul Craciunoiu [:paulc]]

(In reply to comment #11)
> (From update of attachment 378826 [details] [diff] [review])
> Do we need sphinxd restarted on stage/prod for this to take effect?
Yes, I assume you just saw bug 494327 :)

Comment 13

[Laura Thomson :laura]

Yes, immediately afterwards :)  Commented there

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

While trying to populate a solved forum thread, I discovered bug 496272; I'd appreciate any and all help in fixing/verifying either/both :-)

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Well, cool; my recently solved forum post is now showing up correctly on http://support-stage.mozilla.org/tiki-view_forum_thread.php?locale=en-US&comments_parentId=349768&forumId=1.

A search for it doesn't yield it (http://support-stage.mozilla.org/tiki-newsearch.php?where=f&locale=en-US&q=new+forum+topic&sa=), but hopefully it should once Sphinx reindexes, early this AM.

(However, why then don't all results kicked off from the search box on http://support-stage.mozilla.org/en-US/kb/Support+Website+Forums result in "Solved" threads?  e.g. try "Firefox hangs" -- the results aren't for solved threads.)

Comment 16

[E. Cooper [:ecooper]]

I've filed bug 496436 to make sure that /scripts is up to date on stage.

If it isn't, it'll explain why we aren't seeing the expected behavior.

Comment 17

[E. Cooper [:ecooper]]

We're getting 'unsolved' results intermingled with 'solved' results. Bug 496436 says /scripts/sphinx is up to date on staging, so it leads me to believe that either the cron for the forums indexer died or the config update didn't take.

Just to reiterate, locally this is WFM so I don't think it's a code issue.

Comment 18

[Laura Thomson :laura]

This appears to be only on stage which blocks QA for 1.1.

Server-ops, can you please check into the issues mentioned in comment #17?

Comment 19

[chizu]

Scripts is at this revision:
URL: http://svn.mozilla.org/projects/sumo/trunk/scripts
Revision: 27240
Last Changed Author: [e-mail]
Last Changed Rev: 26070
Last Changed Date: 2009-05-21 18:44:20 -0700 (Thu, 21 May 2009)

The config change had gone missing, checking production it's still there, but was reverted on stage.

Comment 20

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED -- the two results are both solved forum threads, which is what I was expecting; thanks!