467809 - Advanced address search recognizes only the first condition

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Henning Henkel]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.4) Gecko/2008111922 GranParadiso/3.0.4
Build Identifier: 20081201162550

When selecting "all conditions must be matched" and searching for example a lastname and a nickname and provide names, I get two matches with the same lastname. But it should only show one match, as the other contact has no nickname.

Reproducible: Always

Steps to Reproduce:
1.Create two contacts with the same or partly the same lastname
2.One of the contacts gets a nickname, the other one not.
3.Press SHIFT + F when in the addressbook 
4.Select "all conditions must be matched"
5.Search for "Name" "contains" the above chosen lastname ( or part of it )
6.Add another codition for the nickname with "contains" and the before chosen nick.
7. Press enter to search
Actual Results:  
Both contact are shown

Expected Results:  
Only the contact should be shown who matches all the conditiones

Comment 1

[Henning Henkel]

As a side effect I noticed that a new search (in the same window by hitting "new search") after the above mentioned procedure does not show any results.

Comment 2

[Phil Ringnalda (:philor)]

Attachment: Fix v.1 [Checkin: Comment 4]

This stops us from bombing out with

Error: uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIRDFService.GetResource]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://messenger/content/ABSearchDialog.js :: GetScopeForDirectoryURI :: line 122"  data: no]

when you change from "Match any" to "Match all", since we're currently trying to setSearchScope(""). Testing it makes another bug rather obvious, since you open the dialog with "Any Name" selected, and when you change to "Match all" that changes to "Display Name" because the "Any Name" item disappears. I'll assert that that's a different bug which this one was just masking, since I don't actually know what's doing that.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 351321 [details] [diff] [review]
Fix v.1
[Checkin: Comment 4]

Please file a bug on the Any Name issue and I'll take a look at it later.

Comment 4

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/5c3297d72cb6

Comment 5

[Wayne Mery (:wsmwk)]

Phil, this made it into b1, do you want the target revised?

Comment 6

[Phil Ringnalda (:philor)]

S'pose so.