Closed Bug 467878 Opened 13 years ago Closed 13 years ago

Define MOZILLA_1_9_1_BRANCH based on milestone.txt, to ifdef for different mozilla-centrals


(Thunderbird :: Build Config, defect)

Not set


(Not tracked)

Thunderbird 3.0b2


(Reporter: philor, Assigned: standard8)



(1 file)

We need to be able to ifdef based on whether we're building on a 1.9.1 Gecko or a 1.9.2/mozilla-central one, so we can do things differently for 1.9.1 and mozilla-central between now and when comm-central branches. Unfortunately, we can't just copy bug 324370's fix for MOZILLA_1_8_BRANCH, since there's only one comm-central

Getting at the whole of milestone.txt is easy, MOZILLA_VERSION in already gets it, but we need some way of saying |if MOZILLA_VERSION.startswith('1.9.1')|
Flags: blocking-thunderbird3+
Assignee: nobody → bugzilla
Attached patch The fixSplinter Review
This detects the 1.9.1 branch and sets the define accordingly. We'll need to sort out about TB/SM/SB versions at some stage, but we can do that in a different bug.
Attachment #351358 - Flags: review?(kairo)
Comment on attachment 351358 [details] [diff] [review]
The fix

I don't fully understand the changequote() stuff and this echo/sed thingy isn't too beautiful, but probably the best we can do in configure.
Attachment #351358 - Flags: review?(kairo) → review+
Comment on attachment 351358 [details] [diff] [review]
The fix

definately right...

changequote there is an autoconf thing that ensures the regex won't do silly things in the future (also note how its changed back to [ and ] after the regex)

and is probably the best we got, as we have to parse MOZILLA_VERSION well
Attachment #351358 - Flags: review+
Checked in with dodgy checkin comment:
Target Milestone: --- → Thunderbird 3.0b2
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
(In reply to comment #4)
> Checked in with dodgy checkin comment:

That was a mistake, I hope?
(In reply to comment #5)
> (In reply to comment #4)
> > Checked in with dodgy checkin comment:
> >
> That was a mistake, I hope?

Yes I managed to push forgetting to set the comment.
You need to log in before you can comment on or make changes to this bug.