Closed Bug 468081 Opened 11 years ago Closed 11 years ago

no confirmation deleting saved searches (virtual folders) which is undoable

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: mail, Assigned: Bienvenu)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

Thunderbird 3.0 Beta 1, BuildID=20081204113938, Mac OS 10.5.5

there is no undo for deleted saved searches
this is true - that's why there's a confirmation dialog.
there is also no confirmation dialog on Thunderbird 3.0 Beta 1 / Mac
ugh, there used to be. The new folder pane must have broken that. I think I'm going to hijack this bug for that regression. It's not quite as bad as it used to be because we've changed delete to only work on folders if no messages are selected, but it's still not good.

In fact, we've lost the confirmation dialog on deleting from the trash as well.
Assignee: nobody → bienvenu
Flags: blocking-thunderbird3+
Keywords: regression
Summary: on can not undo deleting saved searches (virtual folders) → no confirmation deleting saved searches (virtual folders) or sub-folders of trash, both undoable
we used to do this here: http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsMsgFolderDataSource.cpp#2013

but now we don't go through the folder data source, so we'll need to do it in folderPane.js, or the backend somewhere...
OS: Mac OS X → All
Hardware: Macintosh → All
Target Milestone: --- → Thunderbird 3.0b2
Whiteboard: should be easy
Blocks: TB2SM
Attached patch proposed fixSplinter Review
Attachment #358661 - Flags: review?(jminta)
Whiteboard: should be easy → has patch awaiting review
Comment on attachment 358661 [details] [diff] [review]
proposed fix

+      if ((Components.classes["@mozilla.org/embedcomp/prompt-service;1"]
+            .getService(IPS)
+            .confirmEx(window, title, confirmation, IPS.STD_YES_NO_BUTTONS + IPS.BUTTON_POS_1_DEFAULT, 
+                       "", "", "", "", {})) != 0) /* the yes button is in position 0 */

There looks to be an extra set of parens wrapping just the function call? r=jminta with those removed if that's the case.
Attachment #358661 - Flags: review?(jminta) → review+
I looked and we don't confirm deletion from trash in 2.0x, so the regression was really just the virtual folder delete. Fix checked in, with extra parens removed.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Summary: no confirmation deleting saved searches (virtual folders) or sub-folders of trash, both undoable → no confirmation deleting saved searches (virtual folders) which is undoable
Whiteboard: has patch awaiting review
You need to log in before you can comment on or make changes to this bug.