Closed Bug 468124 Opened 14 years ago Closed 14 years ago

upload.py should let UPLOAD_PORT and POST_UPLOAD_CMD actually be optional

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file)

Apparently I messed this up along the way, because if you don't specify either of these, you get an error.
Attached patch add some checksSplinter Review
Pretty trivial, just check for None before doing anything to these vars.
Attachment #352313 - Flags: review?(benjamin)
Attachment #352313 - Flags: review?(benjamin) → review+
Pushed:
http://hg.mozilla.org/mozilla-central/rev/26413234cbfa
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.