468515 - configure doesn't set OS_TEST properly in 64-bit OS X builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

Building with CC="gcc -arch x86_64" CXX="g++ -arch x86_64", I still get -DAVMPLUS_IA32 in my CXXFLAGS. I suspect this has to do with buggy logic for setting this flag in the Makefile. This really ought to get AC_DEFINEd in configure anyway. I've been meaning to clean up the Makefile and move some stuff into configure, maybe I'll take this opportunity to do it.

Comment 1

[Simon Howes]

I came across this a couple of months ago.  We ask 'uname -p', which always outputs i386.


Configure.in lines 1222 to 1234 as an example:


Darwin)
    case "${target_cpu}" in
    powerpc*)
        OS_TEST=ppc
        ;;
    i*86*)
        OS_TEST=i386 
        ;;
    *)
        if test -z "$CROSS_COMPILE" ; then
            OS_TEST=`uname -p`
        fi
        ;;

Comment 2

[(not currently active) Ted Mielczarek]

Aha, thanks! I didn't realize that was the root cause. I have a tiny patch to fix it.

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: set OS_TEST correctly when target_cpu=x86_64 on mac

I'm able to build Spidermonkey without problems with this patch. (Didn't try a full Firefox build, I know that doesn't build.) Note that you still have to run configure like:
CC="gcc -arch x86_64" CXX="gcc -arch x86_64" ../js/src/configure --target=x86_64-apple-darwin

Comment 4

[(not currently active) Ted Mielczarek]

+        If test -z "$CROSS_COMPILE" ; then

Oops, didn't notice this extraneous capitalization. I've reverted that locally.

Comment 5

[Nomis101]

I've tried this patch (without extraneous capitalization) and the Patch for prlink.c from Bug 370766 to build a 64-bit Thunderbird. And now it works much better than before, but stops after 1 Minute with an error. It seems my libiconv from Macports is not 64-bit. So I've build me a 64-bit version of libiconv in /usr/local. But how can I link to that in my mozconfig?

Comment 6

[(not currently active) Ted Mielczarek]

Please keep distinct issues in separate bugs. If there's no bug for that issue, file a new one and make it block bug 468509.

Comment 7

[(not currently active) Ted Mielczarek]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/53a4f376bb71

Comment 8

[Nomis101]

One question, does this patch also find its way into mozilla-1.9.1 after a few days in mozilla-central? Or is this 64-bit thing (at the moment) only for firefox?

Comment 9

[(not currently active) Ted Mielczarek]

Doesn't seem worthwhile to land this in 1.9.1, as the porting effort will be ongoing and unlikely to make 1.9.1.

Comment 10

[(not currently active) Ted Mielczarek]

(That is to say, Thunderbird and SeaMonkey will be able to benefit by building off of mozilla-central, so it probably won't make Thunderbird 3.0.)